1910791 - [wpt-sync] Sync PR 47379 - [layout] Support min-height:min-content/etc on replaced elements.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47379 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47379
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[layout] Support min-height:min-content/etc on replaced elements.

This adds support for min-height:min-content on replaced elements.

If we don't have an aspect ratio we just return the natural-size.
If we do have an aspect ratio - we calculate the replaced size, but
ignore all the block-constraints (similar to the inline axis).

We may revisit this function, e.g:
kNormal -> kIgnoreBlockLengths -> kIgnoreInlineLengths
so return kIndefiniteSize in that case.

Bug: 40151761
Change-Id: I660e238d78fa8cf19109f0323c42c94f7dc86927

Reviewed-on: https://chromium-review.googlesource.com/5747359
WPT-Export-Revision: 25b30b4998af72e5d1d80c9e442d145a67c2ae98

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b636f3f5257068fa8bb83376d39c1365769adecb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 2
FAIL: 4

Chrome

PASS: 2
FAIL: 4

Safari

PASS: 4
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-sizing/replaced-max-height-min-content.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-sizing/replaced-min-height-min-content.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-sizing/svg-no-ar-max-height-min-content.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-sizing/svg-no-ar-min-height-min-content.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17447cda0bd1
[wpt PR 47379] - [layout] Support min-height:min-content/etc on replaced elements., a=testonly
https://hg.mozilla.org/integration/autoland/rev/832cf48bbf82
[wpt PR 47379] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/17447cda0bd1
https://hg.mozilla.org/mozilla-central/rev/832cf48bbf82