1910902 - Remove old sidebar icons no longer and replace with new.

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Nikki Sharpley (:nikkis) (she/her)]

Old:

  skin/classic/browser/sidebars.svg                   (../shared/icons/sidebars.svg)
  skin/classic/browser/sidebars-right.svg             (../shared/icons/sidebars-right.svg)

New (as of Bug 1886847)

  skin/classic/browser/sidebar-collapsed.svg          (../shared/icons/sidebar-collapsed.svg)
  skin/classic/browser/sidebar-collapsed-right.svg              (../shared/icons/sidebar-collapsed-right.svg)

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Firefox Contributors' Quick Reference,
     which has answers to most development questions.
3. Start working on this bug.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #sidebar channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test browser/components/sidebar/tests/.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 2

[EJiro Oghenekome]

"Hi! My name is EJiro Oghenekome. I'm an Outreachy applicant interested in working on this bug. I've read through the description and I'd love to take a shot at this. Could a mentor confirm I can get started? Any hints on where to begin in the codebase would be greatly appreciated!"

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Hi Ejiro. You may work on this. I've updated the first comment to hopefully make it clearer.

You will need to remove the old files and replace any use of them with the corresponding new ones below. eg. sidebars.svg should be replaced with sidebar-collapsed.svg and sidebars-right.svg should be replaced with sidebar-collapsed-right.svg. Once the files are removed, the references to them in browser/themes/shared/jar.inc.mn will also need removing. You can use Searchfox to find all instances where the svgs will need replacing.

Comment 4

[Isaac Briandt]

Attachment: Bug 1910902 - Remove old sidebar icons and replace with new. r=nsharpley

Comment 5

[EJiro Oghenekome]

Attachment: Bug 1910902 - Update sidebar icons and references to use collapsed versions. r=nsharpley

Comment 6

[EJiro Oghenekome]

Hi (In reply to Nikki Sharpley (:nikkis) (she/her) from comment #3)

Hi Ejiro. You may work on this. I've updated the first comment to hopefully make it clearer.

You will need to remove the old files and replace any use of them with the corresponding new ones below. eg. sidebars.svg should be replaced with sidebar-collapsed.svg and sidebars-right.svg should be replaced with sidebar-collapsed-right.svg. Once the files are removed, the references to them in browser/themes/shared/jar.inc.mn will also need removing. You can use Searchfox to find all instances where the svgs will need replacing.

Hi Nikki, I fixed the bug, and it's ready for review

Comment 7

[EJiro Oghenekome]

Attachment: Bug 1910902 - Update sidebar icons and references to use collapsed versions. r=nsharpley

Comment 8

[EJiro Oghenekome]

Attachment: Bug 1910902 - Remove duplicate sidebar icon entries from jar manifest r=nsharpley

Comment 9

[Nikki Sharpley (:nikkis) (she/her)]

Hi Isaac. Thank you for the patch. Apologies, unfortunately Ejiro was the first to claim this bug in the comments and has also submitted a patch. You can abandon this patch now. Please keep an eye out in the Sidebar Matrix channel for more bugs as we post them.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ab144d7d50fa
https://hg.mozilla.org/integration/autoland/rev/a6049ccf9b4f
Update sidebar icons and references to use collapsed versions. r=nsharpley,desktop-theme-reviewers,mconley

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a6049ccf9b4f