Closed Bug 1910920 Opened 1 month ago Closed 1 month ago

Screenshots should use openOrClosedShadowRoot instead of shadowRoot

Categories

(Firefox :: Screenshots, defect, P1)

Product:
Firefox
Component:
Screenshots
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: niklas, Assigned: niklas, NeedInfo)

Details

Attachments

(1 file)

Bug 1910920 - Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=sfoster,kcochrane
48 bytes, text/x-phabricator-request
Details | Review

In bug 1909926, we added the ability to hover over open shadowRoot elements.
We should update to using openOrClosedShadowRoot

Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8c20788de55
Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=kcochrane

Backed out for causing bc failures on browser_shadowRoot_test.js.

[task 2024-08-01T14:43:22.120Z] 14:43:22     INFO - TEST-START | browser/components/screenshots/tests/browser/browser_shadowRoot_test.js
[task 2024-08-01T14:43:22.180Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fb3a3465400 == 1 [pid = 2920] [id = 0]
[task 2024-08-01T14:43:22.181Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7fb3a88caa00) [pid = 2920] [serial = 1] [outer = 0]
[task 2024-08-01T14:43:22.186Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7fb3a3465c00) [pid = 2920] [serial = 2] [outer = 7fb3a88caa00]
[task 2024-08-01T14:43:22.347Z] 14:43:22     INFO - GECKO(1062) | [Parent 1062, Main Thread] WARNING: BounceTrackingState::OnDocumentStartRequest failed.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp:2618
[task 2024-08-01T14:43:22.367Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7fb3a3469000) [pid = 2920] [serial = 3] [outer = 7fb3a88caa00]
[task 2024-08-01T14:43:22.658Z] 14:43:22     INFO - TEST-INFO | started process screentopng
[task 2024-08-01T14:43:22.908Z] 14:43:22     INFO - TEST-INFO | screentopng: exit 0
[task 2024-08-01T14:43:22.908Z] 14:43:22     INFO - Buffered messages logged at 14:43:22
[task 2024-08-01T14:43:22.909Z] 14:43:22     INFO - Entering setup bound 
[task 2024-08-01T14:43:22.910Z] 14:43:22     INFO - TEST-PASS | browser/components/screenshots/tests/browser/browser_shadowRoot_test.js | The screenshots button was added to the nav bar - "[object XULElement]" == true - 
[task 2024-08-01T14:43:22.910Z] 14:43:22     INFO - Leaving setup bound 
[task 2024-08-01T14:43:22.910Z] 14:43:22     INFO - Entering test bound test_selectingElementsInShadowRoots
[task 2024-08-01T14:43:22.911Z] 14:43:22     INFO - Buffered messages finished
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_shadowRoot_test.js | Uncaught exception in test bound test_selectingElementsInShadowRoots - at chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_shadowRoot_test.js:22 - TypeError: can't access property "querySelector", firstTestPageDiv.shadowRoot is null
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - Stack trace:
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - @chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_shadowRoot_test.js:22:35
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1617:15
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:256:21
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1383:14
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1546:17
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - test_selectingElementsInShadowRoots/<@chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_shadowRoot_test.js:13:51
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:121:22
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - async*test_selectingElementsInShadowRoots@chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_shadowRoot_test.js:7:26
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - Leaving test bound test_selectingElementsInShadowRoots
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - downloads panel should be visible: false
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - GECKO(1062) | [Child 2920, IPC I/O Child] WARNING: [6A2126154AE3D501.AEACE1B4BA442EA1]: GetUserData call for port 'E23BE07FC77DECF9.FAE0B8D9DB0CF73D' failed: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:424
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fb3a3465400 == 0 [pid = 2920] [id = 0] [url = https://example.com/browser/browser/components/screenshots/tests/browser/test-page-shadowRoot.html]
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fb3a3465c00) [pid = 2920] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7fb3a88caa00) [pid = 2920] [serial = 1] [outer = 0] [url = https://example.com/browser/browser/components/screenshots/tests/browser/test-page-shadowRoot.html]
[task 2024-08-01T14:43:22.915Z] 14:43:22     INFO - GECKO(1062) | [Child 2920: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7fb3a3469000) [pid = 2920] [serial = 3] [outer = 0] [url = https://example.com/browser/browser/components/screenshots/tests/browser/test-page-shadowRoot.html]
[task 2024-08-01T14:43:23.036Z] 14:43:23     INFO - GECKO(1062) | MEMORY STAT | vsize 3602MB | residentFast 539MB | heapAllocated 285MB
[task 2024-08-01T14:43:23.037Z] 14:43:23     INFO - TEST-OK | browser/components/screenshots/tests/browser/browser_shadowRoot_test.js | took 916ms
[task 2024-08-01T14:43:23.045Z] 14:43:23     INFO - GECKO(1062) | [Child 1255: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fed83b6a000 == 2 [pid = 1255] [id = 10]
[task 2024-08-01T14:43:23.046Z] 14:43:23     INFO - GECKO(1062) | [Child 1255: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7fed8325e800) [pid = 1255] [serial = 21] [outer = 0]
[task 2024-08-01T14:43:23.046Z] 14:43:23     INFO - GECKO(1062) | [Child 1255: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7fed83b6ac00) [pid = 1255] [serial = 22] [outer = 7fed8325e800]
[task 2024-08-01T14:43:23.102Z] 14:43:23     INFO - checking window state
[task 2024-08-01T14:43:23.137Z] 14:43:23     INFO - TEST-START | browser/components/screenshots/tests/browser/browser_test_element_picker.js
Flags: needinfo?(nbaumgardner)
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/388cbeae55f4
Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=kcochrane

https://hg.mozilla.org/mozilla-central/rev/388cbeae55f4

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: