1910948 - Migrate Adjust SDK from v4 to v5

Status: RESOLVED FIXED

(Fenix :: General, task, P2)

Description

[Jonathan Almeida [:jonalmeida]]

Adjust sent out a notification of a new major release for their SDK that has breaking API changes. We will eventually have to move to it, so let's get ahead of it before we start hitting a deadline by investigating and seeing how big of a change this is for us.

Can I keep using SDK v4?

Adjust will continue to make critical updates to SDK v4 through the end of 2024, but all new features will only be released in v5.

Migration link: https://dev.adjust.com/en/sdk/android/migration/v4-to-v5

Comment 1

[Jonathan Almeida [:jonalmeida]]

Ha, ryanvm always one step ahead. Here is a try run he put up: https://treeherder.mozilla.org/jobs?repo=try&revision=5b223db4a30c46dbe28908ecd5d675db16c904d9

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Been a bit of a struggle getting the magic right for gradle-dependencies to see their snapshot repo, but I think the code changes are mostly correct based on their migration guide.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Seems to build and pass tests. I have no idea how to test this beyond that.
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=ece4e40c02253392afda15d56b4e066ea9236c7a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1910948 - Migrate Fenix to Adjust SDK v5.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:RyanVM, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Jonathan Almeida [:jonalmeida]]

Sharing this update for the release date update. If we plan to keep Adjust until Jan, we have until 134 to land the upgrade patches for release users to get it.

Can I keep using SDK v4?

Apps that have integrated SDK v4 will continue to function. Adjust will not update or actively support SDK v4 from January 2025 onwards; all > critical updates and new features will only be released in v5.

Ryan, is this something we should just land or do we need to ask someone first given the current state of our adjust usage?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I got the impression in Dublin that this very much needed permission to land first.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

From the sounds of it, this may just need to be included in any plans for re-enabling Adjust if that's what's eventually decided.

Comment 10

[Chris Peterson [:cpeterson]]

Ryan, do you have time to update your Adjust patch (from version 5.0.0 to the latest, 5.1.0) and land in Nightly 138? We re-enabled Adjust in 136 with an opt-out setting.

https://github.com/adjust/android_sdk/releases

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This didn't require any significant rebasing from the previous iteration which had already gotten r+, so that's nice. Green on Try also.
https://treeherder.mozilla.org/jobs?repo=try&revision=c9bfea5b803af779197385ad042dff35ec4cda3c

That said, I think some sanity checking would be good by someone who better understands this code. John and Roger, can one or both of you please take a look at this and maybe test it out locally a bit just to ensure that things are working as expected with it still? Thanks in advance!

Comment 12

[Roger Yang [:royang]]

Looks good to me.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff746fd90ea7
Migrate Fenix to Adjust SDK v5. r=android-reviewers,mcarare,Roger

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ff746fd90ea7