1910949 - Remove Adjust SDK from Focus

Status: RESOLVED FIXED

(Focus :: General, task, P1)

Description

[Jonathan Almeida [:jonalmeida]]

Adjust sent out a notification of a new major release for their SDK that has breaking API changes. We will eventually have to move to it, so let's get ahead of it before we start hitting a deadline by investigating and seeing how big of a change this is for us.

Can I keep using SDK v4?

Adjust will continue to make critical updates to SDK v4 through the end of 2024, but all new features will only be released in v5.

Migration link: https://dev.adjust.com/en/sdk/android/migration/v4-to-v5

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Seems to build and pass tests. I have no idea how to test this beyond that.
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=ece4e40c02253392afda15d56b4e066ea9236c7a

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1910949 - Remove Adjust SDK from Focus.

Comment 3

[Chris Peterson [:cpeterson]]

Instead of updating Adjust in Focus, we should remove it because we don't use Adjust in Focus.

https://searchfox.org/mozilla-central/rev/d1fbe983fb7720f0a4aca0e748817af11c1a374e/mobile/android/focus-android/plugins/focusdependencies/src/main/java/FocusDependenciesPlugin.kt#17

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something which can be worked on now or should it wait longer?

Comment 5

[Chris Peterson [:cpeterson]]

Now is good. 👍🏻

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I assume this needs some kind of changing?
https://searchfox.org/mozilla-central/source/mobile/android/focus-android/app/src/main/java/org/mozilla/focus/activity/InstallFirefoxActivity.kt#56

Which humorously redirects to https://apps.apple.com/us/app/firefox-private-safe-browser/id989804926?mt=8 (yes, Firefox iOS)

Comment 7

[Mihai Adrian Carare [:mcarare]]

I will remove that part in 1946732.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=53f82e79db7389d6d120602bd6a33f25f614342d

Comment 9

[Chris Peterson [:cpeterson]]

Ryan says we'll need to update the Google Play Store policy declaration for Focus like we did for Klar in bug 1944428.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1cf0f601b1d
Remove Adjust SDK from Focus. r=android-reviewers,joberhauser

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e1cf0f601b1d

Comment 12

[Ryan VanderMeulen [:RyanVM]]

(In reply to Chris Peterson [:cpeterson] from comment #9)

Ryan says we'll need to update the Google Play Store policy declaration for Focus like we did for Klar in bug 1944428.

This is now completed for Focus Nightly and the most recent submission has been accepted. Will need to do the same for Beta and Release as version 137 rides the trains to those channels.