Closed Bug 1911006 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 47399 - [wptrunner] Don't override `HeadlessShellBrowser.make_command()`

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox131 fixed)

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47399 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47399
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

[wptrunner] Don't override HeadlessShellBrowser.make_command()

web-platform-tests/wpt#47229 changed the implementation of ChromeBrowser.port so that it's dynamically set from a free port that chromedriver finds. This broke HeadlessShellBrowser, which tries to use the port number before it's available.

As it turns out, there's no need for HeadlessShellBrowser to override ChromeBrowser.make_command(); the default implementation works fine.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/908e6ea048dd [wpt PR 47399] - [wptrunner] Don't override `HeadlessShellBrowser.make_command()`, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/908e6ea048dd

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.