1911054 - Make the inline preview selectors check for the selected source

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Bug 1871500 review highlighted some discrepancies when using CodeMirror 6, where inlinepreviews for tracer are kept visible when opening any other document other than the one being traced.
https://phabricator.services.mozilla.com/D197118#7497696

We could strengthen the selectors around inline previews to include this logic of checking if the paused/traced location is matching the currently selected source. (That instead of having this logic being kept within mapStateToProps of the InlinePreviews React component)

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1911054 - [devtools] Assume fetchScopes, generateInlinePreview and getInlinePreviews to always work against the currently selected frame.

This help stop passing the selected frame as argument and ensure we never try to fetch data for an outdated frame.
While doing this, I'm adding assertion after each async call to stop execution if we resumed or moved to another frame.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1911054 - [devtools] Only consider inline previews if it matches the currently selected source.

We were doing the check in the mapStateToProps, but only for pausing, not for tracing.
Let's do that consistantly from the selector.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1911054 - [devtools] Make getSelectedFrame selector return the frame for the current thread by default.

This avoids having to pass the current thread from most callsites.
Even the leftovers, still passing a custom thread argument,
should probably be asserting that they are still relevant,
and be working against the currently selected thread.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09f4923c2d48
[devtools] Assume fetchScopes, generateInlinePreview and getInlinePreviews to always work against the currently selected frame. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/16f58009ebdc
[devtools] Only consider inline previews if it matches the currently selected source. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/a84faecace61
[devtools] Make getSelectedFrame selector return the frame for the current thread by default. r=devtools-reviewers,bomsy

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/09f4923c2d48
https://hg.mozilla.org/mozilla-central/rev/16f58009ebdc
https://hg.mozilla.org/mozilla-central/rev/a84faecace61