1911075 - Rename font-stretch to font-width, and make the old property name an alias

Status: REOPENED

(Core :: Layout: Text and Fonts, enhancement)

Description

[onkar]

Steps to reproduce:

1. Try to set font-width: expanded on any HTML element.

Browser version: Firfox nightly 130.0a1 (2024-07-31) (64-bit)

Actual results:

The browser didn't recognize the property name.

Expected results:

The browser should recognize font-width as font-stretch. And font-stretch to continue as a legacy alias.

The font-stretch property has been renamed to font-width in the specification. And font-stretch is now a legacy alias:

• https://drafts.csswg.org/css-fonts/#font-stretch-desc
• font-stretch is unfortunately named w3c/csswg-drafts#551

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Text and Fonts' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

It looks like we haven't implemented the spec resolution in https://github.com/w3c/csswg-drafts/issues/551#issuecomment-1885196273

This might be simple to do. A first step would be updating this code to font-width, and rename related structs. Then add aliases="font-stretch"?

Comment 3

[Jonathan Kew [:jfkthame]]

Yeah, this should be a fairly simple change, I expect -- basically a big search-and-replace, plus the aliasing.

One thing to note is that the change applies to both the property and the separate but related @font-face descriptor. We should make sure to update (and alias) both of these at the same time, to avoid creating extra confusion.

Comment 4

[Jonathan Kew [:jfkthame]]

One related factor that I don't think has been discussed yet is the Canvas2D API, which also uses the unfortunate stretch-based naming.

We should probably try to get a width alias added there as well, for consistency.

Comment 5

[onkar]

Also, if suitable, it would be great if a warning is logged in console logs or shown in the Developer tools->Elements->styles tab when the old font-stretch name is used.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: WIP: Bug 1911075 - [wip] Global replacement of 'stretch' with 'width' for the CSS font-width property & descriptor.

Comment 7

[Jonathan Kew [:jfkthame]]

Attaching a WIP patch that covers much of the global replacement of the "stretch" term with "width"; this builds for me on macOS, but there will no doubt be some residual issues in the other platform back-ends still to be fixed up.

(This does not yet include any aliasing of the old name to the new, which will be required for this to go forward.)

Comment 8

[Diego Ciudad Real Escalante [:descalante]]

Attachment: Bug 1911075 - Rename font-stretch to font-width, and make the old property name an alias. r=jfkthame

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/680518e767fa
https://hg.mozilla.org/integration/autoland/rev/2495a873d2b5
Rename font-stretch to font-width, and make the old property name an alias. r=jfkthame,geckoview-reviewers,webidl,firefox-style-system-reviewers,layout-reviewers,emilio,owlish,dshin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b806b480b8fb
https://hg.mozilla.org/integration/autoland/rev/ceda1e178481
Revert "Bug 1911075 - Rename font-stretch to font-width, and make the old property name an alias. r=jfkthame,geckoview-reviewers,webidl,firefox-style-system-reviewers,layout-reviewers,emilio,owlish,dshin" for causing mochitests failures in test_animation-type-longhand.html.

Comment 11

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in test_animation-type-longhand.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_animation-type-longhand.html | font-stretch is an unseen longhand property

Please also check these mochitests-plain failures.

P.S. These wpt failures also.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61487 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Diego Ciudad Real Escalante [:descalante]]

[:SerbanS] Thank you for the heads up, the latest patch should fix those failures :)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c89df269fe4
https://hg.mozilla.org/integration/autoland/rev/b41420512927
Rename font-stretch to font-width, and make the old property name an alias. r=jfkthame,geckoview-reviewers,webidl,firefox-style-system-reviewers,layout-reviewers,emilio,owlish,dshin,devtools-reviewers,nchevobbe

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c82154d1651
https://hg.mozilla.org/integration/autoland/rev/2dd23e0ae9a8
Revert "Bug 1911075 - Rename font-stretch to font-width, and make the old property name an alias. r=jfkthame,geckoview-reviewers,webidl,firefox-style-system-reviewers,layout-reviewers,emilio,owlish,dshin,devtools-reviewers,nchevobbe" for causing wr failures on font-face-width-descriptor-aliasing.html.

Comment 17

[Iulian Moraru]

Revert for causing wr failures on font-face-width-descriptor-aliasing.html.

• Push with failures

• Failure log

• Backout link

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8dc93c08cab8
https://hg.mozilla.org/integration/autoland/rev/62ae8eb7849e
Rename font-stretch to font-width, and make the old property name an alias. r=jfkthame,geckoview-reviewers,webidl,firefox-style-system-reviewers,layout-reviewers,emilio,owlish,dshin,devtools-reviewers,nchevobbe

Comment 20

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/62ae8eb7849e

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 22

[BugBot [:suhaib / :marco]]

Bug was resolved, but the web-feature font-width (definition file) is not yet marked as supported in Firefox.

Feature bugs are usually automatically closed once the corresponding web-features are marked as supported; this typically happens after the feature reaches release.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx155 relnotes. Would have added it sooner but comment 22 caused this bug to go by unnoticed in the places we try to identify possible release note candidates.

Comment 24

[Dave Letorey]

Associated Pull Requests

• BCD PR
• FF Release PR