1911085 - The "Tabs closed" snackbar is displayed at the top of the screen on tablets/landscape mode

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, defect)

Description

[Delia Pop (Android QA)]

Attachment: TabCLosedSnackbar.mp4

Steps to reproduce

1. Open a tab.
2. On phone devices, change the device orientation to Landscape mode and set the address bar position to Top.
3. Close the tab.
4. Observe the "Close tab" snackbar.

Expected behavior

The "Tabs closed" snackbar is displayed at the bottom of the screen.

Actual behavior

The "Tabs closed" snackbar is displayed at the top of the screen on tablet devices and landscape mode on phone devices.

Device information

• Firefox version: Nightly 130.0a1 from 07/29 until latest
• Android device model/OS version: Samsung Tab S8 Ultra 5G (Android 14), Lenovo Yoga Tab 11 (Android 12), Google Pixel 8 Pro (Android 14), any device

Any additional information?

2024-08-01T16:04:03.567000: INFO : Narrowed nightly regression window from [2024-07-28, 2024-07-30] (2 days) to [2024-07-28, 2024-07-29] (1 days) (~0 steps left)
The issue is still reproducible with the "Enable Navigation Toolbar" option disabled from secret settings.
If there are multiple tabs opened:

• if any tab is closed from a website, the snackbar is correctly displayed at the bottom of the screen.
• if any tab is closed from home page, the snackbar is displayed at the top of the screen.

Comment 1

[Delia Pop (Android QA)]

Petru, can you take a look at this issue? Could be related to 1906657.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Thank you for catching this and for the ping.
Indeed seems like this is a recent regression that only reproduces on large screen sizes - that's why I missed it.
Fix coming right up.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1911085 - Avoid anchoring the snackbar to top toolbars r=#android-reviewers

Recently we introduced a new dependency for the snackbars - toolbarLayout
Which on tablets can appear at the top, similarly to the old toolbar dependency.

Previously this wasn't found and the snackbar would default to be placed at the bottom
of the screen, now we specifically place it as such when using any top toolbar.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d23ec83bdcee
Avoid anchoring the snackbar to top toolbars r=android-reviewers,rsainani

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/d23ec83bdcee

Comment 6

[Delia Pop (Android QA)]

Attachment: media_20240806_181440_6309275559857338957.mp4

Verified as fixed on the latest Nightly 131.0a1 from 08/06 with Samsung Tab S8 Ultra 5G (Android 14), Lenovo Yoga Tab 11 (Android 12), Google Pixel 8 Pro (Android 14). The snackbar is displayed at the bottom of the screen.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9417292 [details]
Bug 1911085 - Avoid anchoring the snackbar to top toolbars r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: When closing all tabs from tabs tray the snackbar informing the user about this is shown at the top of the screen instead as at the bottom like the other snackbars.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Ensure you have a least one tab opened

• Close all from tabs tray
• Observe the snackbar shown on homescreen

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small, targetted change - ensure the proper anchor for toolbars shown on the homescreen.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9417292 [details]
Bug 1911085 - Avoid anchoring the snackbar to top toolbars r=#android-reviewers

Approved for 130.0b3

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/285b3fe3cac3

Comment 10

[Delia Pop (Android QA)]

Verified fixed on Beta 130.0b3 with Samsung Galaxy A53 5G (Android 14).