1911101 - Support all DOM strings as IDB database file names

Status: ASSIGNED

(Core :: Storage: IndexedDB, defect, P4)

Description

[Jari Jalkanen [:jari]]

According to specification, any DOMString should work as an IndexedDB database name but the current implementation is limited to unicode strings. To fix this, it should be ensured that

• the existing database names on disk are still found (i.e. old names keep working) and the databases() API support is not broken (listing the databases considers both old and new names)
• data migration can kept minimal (or avoided altogether) to not hit the memory limits or long waits that appear like hangs for old profiles.

Comment 1

[Jari Jalkanen [:jari]]

Attachment: WIP: Bug 1911101 - Separate user given database name and database file name by type. r=#dom-storage

Users can enter any byte combination as a database name but not all
combinations are valid unicode text. The database names are only stored
in the database itself and there is no master record which could be used
to map a non-textual name to a file. Therefore, we use an encoding of a
non-unicode name as the file name. In this patch, we introduce the
DatabaseFileName type to prevent mixing up the two names.

Comment 2

[Jari Jalkanen [:jari]]

Attachment: WIP: Bug 1911101 - Encode IDB database names as text for file names. r=#dom-storage

Comment 3

[Jari Jalkanen [:jari]]

Attachment: WIP: Bug 1911101 - Extend test_marker_file to consider non-unicode database names. r=#dom-storage