Closed Bug 1911123 Opened 7 months ago Closed 7 months ago

Add configurable description text for checklist items in about:welcome MultiSelect component

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement
Points:
2

Tracking

()

RESOLVED FIXED
130 Branch
Iteration:
131.1 - Aug 5 - Aug 16
Tracking Status
firefox130 --- fixed

People

(Reporter: mviar, Assigned: mviar, NeedInfo)

Details

Attachments

(1 file)

We'll need to add configurable descriptions for items in aboutwelcome's MultiSelect component to support the opt-out telemetry experiment design. The goal is to land these in Nightly Fx131 for us in an experiment in Fx131 release.

Assignee: nobody → mviar
Iteration: --- → 131.1 - Aug 5 - Aug 16
Points: --- → 2
Priority: -- → P2
Attachment #9417315 - Attachment description: WIP: Bug 1911123 - Add configurable description text for checklist items in about:welcome MultiSelect component → Bug 1911123 - Add configurable description text for checklist items in about:welcome MultiSelect component
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/004673f07e49 Add configurable description text for checklist items in about:welcome MultiSelect component r=omc-reviewers,jprickett
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch

Hey Gabrielle, just adding an NI here to capture our slack discussion around the wrap style for checklist items in the split screen about:welcome card layout.

We landed the attached patch last cycle to allow for descriptions under checklist items in about:welcome split view cards to support the opt-out experiment. Before the patch, when checklist labels ran over to multiple lines in some languages they were all indented. After our change, they're not. The screenshots in the patch shows how this looks with in languages with multi-line labels and descriptions together.

From a design standpoint, what are your thoughts on the wrapping below the checkbox? One advantage would be that some languages currently overflow the space and push the buttons down, so this might help that issue somewhat. But, this could also be seen as as a design regression so wanted to run it by you and see if we should land a follow-up refining the styles. We can keep wrapping for both, neither, or just one. It's possible we'd want to keep it for cases with descriptions to ensure we're distinguishing the description text from the label text.

Flags: needinfo?(glussier)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: