191131 - nsDispatchSupport ClassIsListed fn returns wrong listIsEmpty value

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Adam Lock]

nsDispatchSupport.cpp contains a ClassIsListed() function which is meant to read
the registry and say whether a clsid is listed or not. When the key doesn't exist
or cannot be opened, the function puts the wrong value into the listIsEmpty
return value causing the whitelist check further on to fail.

Workaround is to create the SOFTWARE\Mozilla\ActiveX\Whitelist\CLSID key to
ensure the test can open the registry key and count the entries.

Patch follows

Comment 1

[Adam Lock]

Attachment: Patch

David, can you review this? Thanks

Comment 2

[David Bradley]

Comment on attachment 112989 [details] [diff] [review]
Patch

r=dbradley

I like the change to PRBool return value too.

Comment 3

[Adam Lock]

Comment on attachment 112989 [details] [diff] [review]
Patch

Hi Brendan, can I have an sr on this patch to xpconnect to correct check the
COM connect object registry blacklist & whitelist?

Thanks

Comment 4

[Darin Fisher]

Comment on attachment 112989 [details] [diff] [review]
Patch

sr=darin

Comment 5

[Adam Lock]

Comment on attachment 112989 [details] [diff] [review]
Patch

Requesting 1.3b approval. Patch only affects COM connect, is low risk and
corrects a security inaccuracy when trying to read from a registry key that
cannot be found

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 112989 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 7

[Adam Lock]

Fix is in

Comment 8

[Phil Schwartau]

Checkin Verified -