1911316 - Search tip is not displayed after an update

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Found in

• Fx 130.0a1

Affected versions

• Fx 130.0a1

Affected platforms

• Ubuntu 23.04

Preconditions
Have an older version of nightly installed.

Steps to reproduce

1. Launch Firefox.
2. Go to about:config and switch devtools.chrome.enabled to true.
3. Input the following snippet in the browser console:
   (async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();
4. In about:preferences disable the 'default browser' check.
5. Update and restart the browser to apply it.
   5.1. No "search tip" is displayed after the restart on a newly opened tab
6. Close the browser.
7. Go to the install folder and delete the update.xml file (and active-update.xml if it exists).
8. Open Firefox again.

Expected result

• URL section is highlighted and focused. There is a Search tip displayed.

Actual result

• No search tip is displayed.

Regression range

• Will look into a regression range ASAP.

Comment 1

[Cristian Baica [:cbaica], Release Desktop QA]

Upon investigating this further I realized that getting a regression range for this is a bit impossible, as the upgrade process will always bring the latest version of Fx instead of an earlier version to see if it reproduces there or not. And the upgrade process is mandatory for it creates the update.xml filme connection.

Comment 2

[James Teow [:jteow]]

Cristian, was this a recent find? Or was this QA test passing throughout this year?

Daisuke modified search tips in Bug 1620576 about a year ago so that it pulls from two different prefs:
browser.laterrun.bookkeeping.profileCreationTime (when the profile was created) and browser.laterrun.bookkeeping.updateAppliedTime (when the profile was last updated) which are set in LaterRun.sys.mjs.

I suspect what might be happening is if you're testing with a new installed application, the creation time is outside the window of showing search tips (we don't show them if the user updated their browser OR installed the browser within a 24 hour period).

I think if you manually set browser.laterrun.bookkeeping.profileCreationTime and browser.laterrun.bookkeeping.updateAppliedTime to any time 24 hours before the current time, and restart the browser, the search tips should return.

Comment 3

[Cristian Baica [:cbaica], Release Desktop QA]

Re-tested using the following scenario:

1. Launch Firefox.
2. In about:preferences disable the 'default browser' check.
3. Update and restart the browser to apply it.
4. No "search tip" is displayed after the restart on a newly opened tab.
5. Go to about:config and set browser.laterrun.bookkeeping.profileCreationTime to 24 hourse before the current time.
6. Restart the browser and then open a new tab.

Search tip is correctly displayed again.
Closing this as WFM and will update the QA testcase.