Closed Bug 191135 Opened 23 years ago Closed 23 years ago

[FIXr]FIELDSET doesn't keep content within

Categories

(Core :: Layout: Form Controls, defect, P2)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.3final

People

(Reporter: bugzilla.mozilla.org, Assigned: bzbarsky)

Details

Attachments

(3 files)

the testcase
519 bytes, text/html
Details
proposed fix
738 bytes, patch
john
: review+
roc
: superreview+
asa
: approval1.3+
Details | Diff | Splinter Review
modified estcase to check the patch
570 bytes, text/html
Details
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030121 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030121 hm, bad summara probalbly, sorry ... now: a FIELDSET with fixed size, in there a DIV with Height at 100%, overflow scroll works not as expected note: it's not the DIF, same happens with other elements inside a FIELDSET, the fieldset just does not keep the content inside Reproducible: Always Steps to Reproduce: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> <html> <head><title>Untitled</title></head> <body> <fieldset style="height:100px;border:1px solid blue;"> <legend>Legend</legend> <div style="height:100%; border:1px solid red; overflow:scroll;">content, id.e. a form ...<br>new line<br>another line<br>another line<br>another line<br>another line<br>another line<br>another line<br>another line<br>another line<br>another line<br>another line</div> </fieldset> </body> </html> Actual Results: DIV exceeds the borders of the foeldset Expected Results: DIV should be kept within the FIELDSET and become scrollbars
DIV should be kept within the FIELDSET and have scrollbars
Attached file the testcase —
Attached patch proposed fix — — Splinter Review
Comment on attachment 113022 [details] [diff] [review] proposed fix We should fix fieldset frame construction to not suck... :(
Attachment #113022 - Flags: superreview?(roc+moz)
Attachment #113022 - Flags: review?(jkeiser)
taking
Assignee: form → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Priority: -- → P2
Hardware: PC → All
Summary: FIELDSET doesn't keep content within → [FIX]FIELDSET doesn't keep content within
Target Milestone: --- → mozilla1.3final
Attachment #113022 - Flags: review?(jkeiser) → review+
Comment on attachment 113022 [details] [diff] [review] proposed fix sr=roc+moz
Attachment #113022 - Flags: superreview?(roc+moz) → superreview+
Summary: [FIX]FIELDSET doesn't keep content within → [FIXr]FIELDSET doesn't keep content within
Comment on attachment 113022 [details] [diff] [review] proposed fix Could this please be approved for 1.3? All this does is make percent-height kids of fieldsets use the right height for the percentage base...
Attachment #113022 - Flags: approval1.3?
Comment on attachment 113022 [details] [diff] [review] proposed fix a=asa (on behalf of drivers) for checkin to 1.3 final.
Attachment #113022 - Flags: approval1.3? → approval1.3+
fixed for 1.3final
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
finally I got my hands on a build that contains the fix. There still seems something odd about the rendering. In the attached testcase the <div> flows slightly over the containing FIELDSET Looks like the space on top that is covered by the label element shifts the DIV down a little. MSIE fits the div perfectly in the fieldset. Now, whats the correct behaviour? Sure, the div has height=100% , so the div has the same height as the fieldset and since there is something at the top of the fieldset that occupies some pixels the div gets move down a bit for those some pixels. - sounds logical but looks bad :(
> Now, whats the correct behaviour? Ours, as you noted, follows the CSS box model. IE's does not. The fact that it looks bad just tells you that those are not the style rules you want to use...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: