1911516 - ML Fails in non-debug mode because of maxLogLevelPref

Status: RESOLVED FIXED

(Core :: Machine Learning, defect, P1)

Description

[Tarek Ziadé (:tarek)]

I tried the feature in a beta simul and it fails because we use maxLogLevelPref in the worker, and that will throw an exception in non-debug builds. Since I work in debug I missed it.

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Bug 1911516 - remove maxLogLevelPref usage from the worker r?calixte,atossou,mardak

Depends on D218407

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a0171aa06f0
remove maxLogLevelPref usage from the worker r=calixte

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: Bug 1911516 - remove maxLogLevelPref usage from the worker r?calixte,atossou,mardak

Original Revision: https://phabricator.services.mozilla.com/D218515

Comment 4

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: the pdf.js new alt text feature will not work at all
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: very low because that feature is a nimbus experiment and the code changed is only inside the feature
• Explanation of risk level: n/a
• String changes made/needed: no
• Is Android affected?: no

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7a0171aa06f0

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ca4a2726c8e