191157 - [AxPlugin] WMP9 control doesn't display

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

The WMP9 final control doesn't display. I've isolated the problem to a single
return code which it now seems to care about. XPCDocument::get_URL should return
S_OK.

No-brain patch follows

Comment 1

[Adam Lock]

Attachment: Patch

Return S_OK, not E_FAIL

Comment 2

[Adam Lock]

Comment on attachment 113001 [details] [diff] [review]
Patch

Can I have an r/sr on this trivial patch to fix hosting of the Windows Media
Player control in my ActiveX plugin?

Thanks

Comment 3

[David Bradley]

Comment on attachment 113001 [details] [diff] [review]
Patch

r=dbradley

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 113001 [details] [diff] [review]
Patch

sr=blizzard

Comment 5

[Adam Lock]

Comment on attachment 113001 [details] [diff] [review]
Patch

Requesting 1.3b approval. No risk associated with patch, fixes regression in
COM connect work.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 113001 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 7

[Adam Lock]

Fix checked in