1911639 - Suggest Metrics (JS side)

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Ben Dean-Kawamura [:bdk]]

Split off from https://bugzilla.mozilla.org/show_bug.cgi?id=1901779

Adding metrics is complicated by the fact that we can't call Glean directly, but need to forward the calls through our consumers. However, for queries it's not so hard. We can return a metrics struct alongside the query results, like how SyncManager returns them as part of SyncResult.

This issue is for taking the metrics that Rust returns in https://bugzilla.mozilla.org/show_bug.cgi?id=1911638 and recording them with Glean on the JS side.

Query metrics:

• Total query time
• Query time for each individual provider
• To keep things backwards-compatible, let's use a new method name like query_with_metrics.

Ingest metrics:

• time to download data (total and also per-provider)
• time to update the database (total and also per-provider)

Comment 1

[Drew Willcoxon :adw]

This might belong better in Firefox :: Address Bar.

Comment 2

[Ben Dean-Kawamura [:bdk]]

Attachment: Bug 1911639 - Record Suggest metrics, r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba03fbbe15cf
Record Suggest metrics, r=adw

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/ba03fbbe15cf