1911647 - Update googletest to new version ff233bdd4cac0a0bf6e5cd45bda3406814cb2796 from 2024-08-01 13:34:56

Status: RESOLVED FIXED

(Testing :: GTest, enhancement)

Description

[Update Bot]

This update covers 15 commits. Here are the overall diff statistics, and then the commit information.

---

third_party/googletest/BUILD.bazel | 26 +-
third_party/googletest/CMakeLists.txt | 2 +-
third_party/googletest/MODULE.bazel | 24 ++-
third_party/googletest/README.md | 14 +-
third_party/googletest/WORKSPACE | 39 +++++-
third_party/googletest/googlemock/include/gmock/gmock-actions.h | 67 +++++++--
third_party/googletest/googlemock/include/gmock/gmock-matchers.h | 44 ++++--
third_party/googletest/googlemock/include/gmock/gmock-more-actions.h | 7 +-
third_party/googletest/googlemock/include/gmock/gmock-spec-builders.h | 10 +-
third_party/googletest/googlemock/include/gmock/internal/gmock-port.h | 1 +
third_party/googletest/googlemock/src/gmock-cardinalities.cc | 8 +-
third_party/googletest/googletest/README.md | 2 +-
third_party/googletest/googletest/include/gtest/gtest.h | 4 +-
third_party/googletest/googletest/include/gtest/internal/gtest-type-util.h | 6 +-
third_party/googletest/googletest_deps.bzl | 20 +-
third_party/googletest/moz.yaml | 4 +-
16 files changed, 182 insertions(+), 96 deletions(-)

---

ff233bdd4cac0a0bf6e5cd45bda3406814cb2796 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/ff233bdd4cac0a0bf6e5cd45bda3406814cb2796
Authored: 2024-08-01 06:34:07 -0700
Committed: 2024-08-01 06:34:56 -0700

Update main to point to 1.15.2 patch release

PiperOrigin-RevId: 658382055
Change-Id: Ia5eed4bec26da8c8cbe29fbd3a41b44048c25e07

Files Modified:

• CMakeLists.txt
• README.md
• docs/quickstart-bazel.md
• googletest/README.md

---

3e3b44c300b21eb996a2957782421bc0f157af18 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/3e3b44c300b21eb996a2957782421bc0f157af18
Authored: 2024-07-30 13:17:08 -0700
Committed: 2024-07-30 13:17:40 -0700

Remove auto-detection of Python toolchain from MODULE.bazel since it affects downstream users

The correct solution appears to be
https://rules-python.readthedocs.io/en/stable/toolchains.html#library-modules-with-dev-only-python-usage

This change also includes a workaround for the new mechanism creating
paths that are too long for Windows to handle.

Fixes #4581

PiperOrigin-RevId: 657706984
Change-Id: I8ae6b9e5efeb7629d79d14e7d4d3889876282d17

Files Modified:

• MODULE.bazel
• ci/windows-presubmit.bat

---

ffa31aec1cbbe0d18398647c0bc3292b4af5efbf by Abseil Team <[e-mail]>

https://github.com/google/googletest/commit/ffa31aec1cbbe0d18398647c0bc3292b4af5efbf
Authored: 2024-07-30 09:02:44 -0700
Committed: 2024-07-30 09:03:18 -0700

Directly include gmock.h and gtest.h in gmock-matchers tests.

These headers have been included through gmock-matchers_test.h

PiperOrigin-RevId: 657612455
Change-Id: I65675f1cfe7789f1821ccacbe60acf90efd5c221

Files Modified:

• googlemock/test/gmock-matchers-arithmetic_test.cc
• googlemock/test/gmock-matchers-comparisons_test.cc
• googlemock/test/gmock-matchers-containers_test.cc
• googlemock/test/gmock-matchers-misc_test.cc

---

5bcb2d78a16edd7110e72ef694d229815aa29542 by Abseil Team <[e-mail]>

https://github.com/google/googletest/commit/5bcb2d78a16edd7110e72ef694d229815aa29542
Authored: 2024-07-24 08:07:22 -0700
Committed: 2024-07-24 08:07:57 -0700

Use matcher's description in AllOf if matcher has no explanation.

PiperOrigin-RevId: 655569834
Change-Id: Ia760d74d1cdde766e9719864c5e19c0159da3128

Files Modified:

• googlemock/include/gmock/gmock-matchers.h
• googlemock/test/gmock-matchers-arithmetic_test.cc
• googlemock/test/gmock-matchers-comparisons_test.cc

---

352788321faa2f2aa7a098a5a6e53053059b934b by Aaron Jacobs <[e-mail]>

https://github.com/google/googletest/commit/352788321faa2f2aa7a098a5a6e53053059b934b
Authored: 2024-07-23 19:43:05 -0700
Committed: 2024-07-23 19:43:42 -0700

gmock-actions: make DoAll convert to OnceAction via custom conversions.

Currently it will refuse to become a OnceAction if its component sub-actions
have an Action conversion operator but don't know about OnceAction in
particular because although Action is convertible to OnceAction, the
compiler won't follow the chain of conversions.

Instead, teach it explicitly that it can always be a OnceAction when it can be
an Action.

PiperOrigin-RevId: 655393035
Change-Id: Ib205b518ceef5f256627f4b02cd93ec9bd98343b

Files Modified:

• googlemock/include/gmock/gmock-actions.h
• googlemock/test/gmock-actions_test.cc

---

57e107a10ea4ff5d8d31df9e4833f80b414b0dd2 by Aaron Jacobs <[e-mail]>

https://github.com/google/googletest/commit/57e107a10ea4ff5d8d31df9e4833f80b414b0dd2
Authored: 2024-07-23 03:56:40 -0700
Committed: 2024-07-23 03:57:23 -0700

Run clang-format.

PiperOrigin-RevId: 655106304
Change-Id: Ie69b407fce74b31cf71d6dcc1361910d30e86bb5

Files Modified:

• googlemock/include/gmock/gmock-actions.h
• googlemock/include/gmock/gmock-more-actions.h
• googlemock/include/gmock/gmock-spec-builders.h
• googlemock/include/gmock/internal/gmock-port.h
• googlemock/src/gmock-cardinalities.cc
• googlemock/test/gmock-actions_test.cc
• googlemock/test/gmock-matchers-comparisons_test.cc
• googlemock/test/gmock_link_test.h

---

cee1ba1f24fb12b9ae8f31e70dca3f73dbb12cc2 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/cee1ba1f24fb12b9ae8f31e70dca3f73dbb12cc2
Authored: 2024-07-20 23:08:58 -0700
Committed: 2024-07-20 23:09:44 -0700

Change the Bazel build to use the canonical repo names used by Bzlmod and the Bazel Central Registry

GoogleTest and its dependencies now use the following names:
GoogleTest: com_google_googletest -> googletest
Abseil: com_google_absl -> abseil-cpp
RE2: com_googlesource_code_re2 -> re2

Bazel users using the WORKSPACE file to specify dependencies may
need to use https://bazel.build/rules/lib/repo/http#http_archive-repo_mapping
to remap repositories to their former names if their dependencies do not
agree on on which name is used.

It is recommended that users migrate to bzlmod to manage Bazel dependencies.

PiperOrigin-RevId: 654430227
Change-Id: Iae8797994d7d87bd4f013dcdc889e7494a6ad2fb

Files Modified:

• BUILD.bazel
• MODULE.bazel
• WORKSPACE
• googletest_deps.bzl

---

9ff2450a56aed4f7f124f5104d9e3088bf791ee9 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/9ff2450a56aed4f7f124f5104d9e3088bf791ee9
Authored: 2024-07-16 06:57:41 -0700
Committed: 2024-07-16 06:58:45 -0700

Update GoogleTest Bazel quickstart for Bzlmod

PiperOrigin-RevId: 652824490
Change-Id: I5e6f57004708e7fa62abb454db9bae81fa265c83

Files Modified:

• docs/quickstart-bazel.md

---

b62593aceb9bbd4b423804855d3eba5386eb6dc8 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/b62593aceb9bbd4b423804855d3eba5386eb6dc8
Authored: 2024-07-16 06:56:59 -0700
Committed: 2024-07-16 06:57:43 -0700

Update main branch to reflect the release of 1.15.0

PiperOrigin-RevId: 652824317
Change-Id: I39085d9451405c3decb462a0b4682added365d17

Files Modified:

• CMakeLists.txt
• README.md
• googletest/README.md

---

d49a6654845491fcb2c1d05ef20648c5b7bed783 by Abseil Team <[e-mail]>

https://github.com/google/googletest/commit/d49a6654845491fcb2c1d05ef20648c5b7bed783
Authored: 2024-07-16 05:22:04 -0700
Committed: 2024-07-16 05:22:42 -0700

Use matcher's description in AllOf if matcher has no explanation.

PiperOrigin-RevId: 652798234
Change-Id: I8e92248a2d9faf2a5719fe220145ea563acc14ff

Files Modified:

• googlemock/include/gmock/gmock-matchers.h
• googlemock/test/gmock-matchers-arithmetic_test.cc
• googlemock/test/gmock-matchers-comparisons_test.cc

---

417158b8bca158426cbdc0c547fdd7d9fbd46904 by Abseil Team <[e-mail]>

https://github.com/google/googletest/commit/417158b8bca158426cbdc0c547fdd7d9fbd46904
Authored: 2024-07-15 16:39:22 -0700
Committed: 2024-07-15 16:40:10 -0700

Use matcher's description in AllOf if matcher has no explanation.

PiperOrigin-RevId: 652634229
Change-Id: I5fd7eaef4db3dea3d4142e1fb5fc97e46f654358

Files Modified:

• googlemock/include/gmock/gmock-matchers.h
• googlemock/test/gmock-matchers-arithmetic_test.cc
• googlemock/test/gmock-matchers-comparisons_test.cc

---

7321f950dfe0d481b56b1c475e38b681ff34263f by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/7321f950dfe0d481b56b1c475e38b681ff34263f
Authored: 2024-07-15 07:50:21 -0700
Committed: 2024-07-15 07:51:06 -0700

Update dependency versions in preparation for release

PiperOrigin-RevId: 652479800
Change-Id: I71574e7dc2ea2e9a2f3071aebbbf0e6b5ce32a35

Files Modified:

• MODULE.bazel
• WORKSPACE
• googletest_deps.bzl

---

4b21f1abddaf7d28388d7430bab69a81eccb1909 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/4b21f1abddaf7d28388d7430bab69a81eccb1909
Authored: 2024-07-12 10:30:28 -0700
Committed: 2024-07-12 10:31:17 -0700

README.md: Remove outdated notes about continuous integration and documentation

PiperOrigin-RevId: 651816538
Change-Id: I3c85b4a26aff8277c627b99b1c5805bad0d29df6

Files Modified:

• README.md

---

b4aaf97d8f7eaffab79aa15e10a91b331b941fe2 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/b4aaf97d8f7eaffab79aa15e10a91b331b941fe2
Authored: 2024-07-10 09:14:40 -0700
Committed: 2024-07-10 09:15:21 -0700

Workaround GCC 12 -Wrestrict false-positive

Suggested workaround from https://github.com/Nekto89/googletest/commit/751760ad543f205e1d76797bcc5c7e2ca0c30cce

Fixes #4570

PiperOrigin-RevId: 651044944
Change-Id: I21f099a15dd3182d335a7891d99b9b1293e5c53e

Files Modified:

• googletest/include/gtest/internal/gtest-type-util.h

---

3ef16ef8b30f52a8f1ff677faa1730e76835aa40 by Derek Mauro <[e-mail]>

https://github.com/google/googletest/commit/3ef16ef8b30f52a8f1ff677faa1730e76835aa40
Authored: 2024-07-09 12:58:46 -0700
Committed: 2024-07-09 12:59:38 -0700

Fix the documentation that erroneously says you can use short versions of help flags

Fixes #4564

PiperOrigin-RevId: 650730047
Change-Id: I3a52aca490338066c607e34ab20c827bfde5090d

Files Modified:

• docs/advanced.md

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=d7e49321ec82f6fc00bc4f91be5866b583f2c26b

Comment 2

[Update Bot]

Attachment: Bug 1911647 - Update googletest to ff233bdd4cac0a0bf6e5cd45bda3406814cb2796

Comment 3

[Update Bot]

Attachment: Bug 1911647 - Apply mozilla patches for googletest

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• source-test-doc-generate - 4 of 4 failed on the same (retriggered) task (failed: JIjqTrKZRfWm_8MY488Ohw, BgDfg4noRDW42_rzWKknpw, H4xMWKaHThC62n4svk-nWQ, RXzOcYgaRu2Htah9Jyk4Ww)

Known Issues:

• toolkit/components/extensions/test/mochitest/test_ext_listener_proxies.html
  - test-linux1804-64-qr/debug-mochitest-plain-xorig-12 (SgN6mFdfQMOUXE2plFmRhA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor third_party/googletest/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1911647 - Apply mozilla patches for googletest, r?jmaher

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1911647 - Fix conflicts in googletest patch file, r?jmaher

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: WIP: Bug 1911647 - Update googletest to ff233bdd4cac0a0bf6e5cd45bda3406814cb2796

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ab41041d5c
Update googletest to ff233bdd4cac0a0bf6e5cd45bda3406814cb2796 r=ahal
https://hg.mozilla.org/integration/autoland/rev/bbdac334ab32
Apply mozilla patches for googletest, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/e027f2bdd5be
Fix conflicts in googletest patch file, r=jmaher

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/63ab41041d5c
https://hg.mozilla.org/mozilla-central/rev/bbdac334ab32
https://hg.mozilla.org/mozilla-central/rev/e027f2bdd5be