1911650 - Update PDF.js to new version 9ac05e797c9677ce28028b026c69722e8f16961d from 2024-08-05 16:34:36

Status: RESOLVED DUPLICATE of bug 1912839

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 8 commits. Here are the overall diff statistics, and then the commit information.

---

taskcluster/kinds/fetch/toolchains.yml | 2 +-
toolkit/components/pdfjs/content/build/pdf.mjs | 45 ++++++--------
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 10 +--
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 6 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 1 -
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 27 ++++----
toolkit/components/pdfjs/content/web/viewer.css | 6 --
toolkit/components/pdfjs/content/web/viewer.mjs | 26 ++++----
toolkit/components/pdfjs/moz.yaml | 4 +-
9 files changed, 55 insertions(+), 72 deletions(-)

---

995f5a29aa9c147d129ea3b55d4ab1b4be38ae51 by Nicolò Ribaudo <[e-mail]>

https://github.com/mozilla/pdf.js/commit/995f5a29aa9c147d129ea3b55d4ab1b4be38ae51
Authored: 2024-08-05 14:35:54 +0200
Committed: 2024-08-05 15:14:05 +0200

Update the Babel plugin to remove empty static blocks

This commit updates the Babel plugin to:

• apply the same flattening logic that we already
  have for blocks, to flatten blocks nested inside
  class static blocks
• remove class static blocks when, after flattening
  all the blocks they contain, they are empty.

Before this commit, the transform output was the
same as the input.

Files Added:

• external/builder/fixtures_babel/staticblock-expected.js
• external/builder/fixtures_babel/staticblock.js

Files Modified:

• external/builder/babel-plugin-pdfjs-preprocessor.mjs

---

0eac5e9d6f6e0def7e96c76c18b02f4e85328fc7 by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/0eac5e9d6f6e0def7e96c76c18b02f4e85328fc7
Authored: 2024-08-05 12:22:38 +0200
Committed: 2024-08-05 12:27:53 +0200

Define a few editor event handler functions inline

Given that we're removing event listeners with AbortSignal it's no longer necessary to keep a reference to a few of the event handler functions in order to remove them.
Hence we can simply inline the relevant bind-calls instead, which reduces the code-size a tiny bit.

Files Modified:

• src/display/editor/highlight.js
• src/display/editor/tools.js

---

356d54175bf0150b48e3b14810915024033a213c by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/356d54175bf0150b48e3b14810915024033a213c
Authored: 2024-08-04 19:57:50 +0200
Committed: 2024-08-04 20:14:43 +0200

Use the waitForEvent helper function in the text layer integration tests

The waitForClick helper function is functionality-wise mostly a
reduced copy of the more generic waitForEvent helper function that
we use for other integration tests, so we can safely replace it to
reduce the amount of code.

Moreover, the waitForClick code is prone to intermittent failures
given recent assertion failures we have seen on the bots (one of them
is linked in #18396) while waitForEvent has recently been fixed to
avoid intermittent failures, so usiong it should also get rid of the
flakiness for these integration tests.

Files Modified:

• test/integration/text_layer_spec.mjs

---

f7d2145782ad9e81a176381b4d289368e10c422f by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/f7d2145782ad9e81a176381b4d289368e10c422f
Authored: 2024-08-04 19:24:43 +0200
Committed: 2024-08-04 19:24:43 +0200

Upgrade postcss-nesting to version 13.0.0

This is a major version bump, but the changelog at
https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-nesting/CHANGELOG.md
doesn't indicate any breaking changes that should impact us.

Files Modified:

• package-lock.json
• package.json

---

1dfdb59f0be9bfcfff6a2a253e8bee31d3355d6c by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/1dfdb59f0be9bfcfff6a2a253e8bee31d3355d6c
Authored: 2024-08-04 19:23:10 +0200
Committed: 2024-08-04 19:23:10 +0200

Upgrade postcss-dir-pseudo-class to version 9.0.0

This is a major version bump, but the changelog at
https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-dir-pseudo-class/CHANGELOG.md
doesn't indicate any breaking changes that should impact us.

Files Modified:

• package-lock.json
• package.json

---

762b16c08aa1f5933b3ef246bede5383cffbff89 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/commit/762b16c08aa1f5933b3ef246bede5383cffbff89
Authored: 2024-08-04 19:20:36 +0200
Committed: 2024-08-04 19:20:36 +0200

Update dependencies to the most recent versions

Files Modified:

• package-lock.json
• package.json

---

4b7f9a8d87ae26f190bcffd308db07c9512c5383 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/commit/4b7f9a8d87ae26f190bcffd308db07c9512c5383
Authored: 2024-08-02 21:49:00 +0200
Committed: 2024-08-02 21:51:27 +0200

Empty fields are 0 when using AFSimple_Calculate

It fixes #18536 and #18532.

Files Added:

• test/pdfs/issue18536.pdf

Files Modified:

• src/scripting_api/aform.js
• test/integration/scripting_spec.mjs
• test/pdfs/.gitignore

---

ecbd660609ff3b50c55e2e30b6d7be6a959ff843 by Jonas Jenwald <[e-mail]>

https://github.com/mozilla/pdf.js/commit/ecbd660609ff3b50c55e2e30b6d7be6a959ff843
Authored: 2024-08-02 20:41:41 +0200
Committed: 2024-08-02 20:46:13 +0200

Stop sending the unused options parameter to various download-methods in the viewer

The options handling, for the download-methods, was originally added in PR 16391 and became obsolete in PR 17771.

This fixes failures, in mozilla-central tests, which appeared after landing PR 18527.

Files Modified:

• web/app.js
• web/download_manager.js
• web/firefoxcom.js
• web/interfaces.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=b6315e593b7016030f202b750942521ef5e5807a

Comment 2

[Update Bot]

Attachment: Bug 1911650 - Update PDF.js to 9ac05e797c9677ce28028b026c69722e8f16961d

Comment 3

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• source-test-taskgraph-diff - 4 of 4 failed on the same (retriggered) task (failed: SUTjI9M7TxO_BaNUlykVXg, b75olebsTCmp8r2xZN8Hbg, C_oNknCiTc2urPm0eEs2pQ, JlmP5E9-QBKKqfqlc7ElBg)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).