1911664 - Suggest Metrics (data review for part 1)

Status: RESOLVED FIXED

(Application Services :: Suggest, enhancement)

Description

[Ben Dean-Kawamura [:bdk]]

Split off from https://bugzilla.mozilla.org/show_bug.cgi?id=1901779

Adding metrics is complicated by the fact that we can't call Glean directly, but need to forward the calls through our consumers. However, for queries it's not so hard. We can return a metrics struct alongside the query results, like how SyncManager returns them as part of SyncResult

This issue is for data review for these metrics:

Query metrics:

• Total query time
• Query time for each individual provider

Ingest metrics:

• time to download data (total and also per-provider)
• time to update the database (total and also per-provider)

Comment 1

[Ben Dean-Kawamura [:bdk]]

Attachment: Data Review form

Comment 2

[Ben Dean-Kawamura [:bdk]]

This is my first time using bugzilla for data review, the DX was pretty slick. I hope I didn't mess it up too badly. Here's the PR with changes: https://github.com/mozilla/application-services/pull/6338.

Comment 3

[Travis Long [:travis_]]

Comment on attachment 9417941 [details]
Data Review form

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored by :bdk

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 4

[Ben Dean-Kawamura [:bdk]]

Thanks Travis. I'm excited to try out the new labeled timing distributions.