1911750 - layers.acceleration.force-enabled is enabled on Android by default

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Gregory Pappas [:gregp]]

layers.acceleration.force-enabled has been 'temporarily' enabled by default on Android for about 12 years (bug 838603)

on Android, accidentally blacklisting OpenGL layers means a startup crash for everyone. Temporarily force-enable GL compositing. This is default-disabled deep within the bowels of the widgetry system.
Remove me when GL compositing isn't default disabled in widget/android.

https://searchfox.org/mozilla-central/rev/213d5278e59db7e6142e2b093d3fd0172f6392a4/modules/libpref/init/StaticPrefList.yaml#8382-8391

This seems like a hack that shouldn't be necessary these days? gfxAndroidPlatform::AccelerateLayersByDefault returns true, so it seems like we could switch the default value of this pref back to false and there would be no behavior change.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Without looking into this closely it seems reasonable to me. Jamie?

Comment 2

[Jamie Nicol [:jnicol]]

Yeah this seems reasonable. I tested setting it false and we still get acceleration. And then tested setting layers.acceleration.disabled to true, and we no longer get a startup crash, we instead get software webrender with GL compositing. So let's remove it

Comment 3

[Gregory Pappas [:gregp]]

Attachment: Bug 1911750 - Disable layers.acceleration.force-enabled on Android

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ae21b991a94
Disable layers.acceleration.force-enabled on Android r=jnicol

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9ae21b991a94