1911760 - mozintl: "skr" is incorrectly defined in region() instead of language() set

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Bug 1899905 added skr to the availableLocaleDisplayNames.region but did not add a corresponding entry in regionNames.ftl. So getRegionDisplayNames will give a fluent error for missing region-name-skr.

Was it meant to be added to availableLocaleDisplayNames.language instead?

Comment 1

[BugBot [:suhaib / :marco]]

:bolsson, since you are the author of the regressor, bug 1899905, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Francesco Lodolo [:flod]]

Thanks for catching, that's indeed an error.

So getRegionDisplayNames will give a fluent error for missing region-name-skr.

I haven't been able to trigger this error. When do you see it?

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1911760 - Move skr from region to language set in mozIntl, r=eemeli

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58322f347f7f
Move skr from region to language set in mozIntl, r=eemeli

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

I haven't been able to trigger this error. When do you see it?

It comes from Tor Browser. When a user is having trouble connecting to tor due to censorship, they can select their region to find them a suitable tor bridge. We basically do the following:

const codes = Services.intl.getAvailableLocaleDisplayNames("region");
const names = Services.intl.getRegionDisplayNames(undefined, codes);

With ESR 128 we started getting the fluent error message.

Comment 6

[Francesco Lodolo [:flod]]

I'll wait for this to land, test it, and then request uplift to beta and ESR128.

Comment 7

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1899905

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/58322f347f7f

Comment 9

[Francesco Lodolo [:flod]]

Verified on Nightly Saraiki build (20240806211239), the language name is now displayed correctly in the accept-languages dialog.

Comment 10

[Francesco Lodolo [:flod]]

Attachment: Bug 1911760 - Move skr from region to language set in mozIntl, r=eemeli

Original Revision: https://phabricator.services.mozilla.com/D218628

Comment 11

[Francesco Lodolo [:flod]]

Attachment: Bug 1911760 - Move skr from region to language set in mozIntl, r=eemeli

Original Revision: https://phabricator.services.mozilla.com/D218628

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users of Saraiki (skr) builds will see the language displayed as [skr] in the accept-languages dialog.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: No
• Risk associated with taking this patch: None
• Explanation of risk level: skr was incorrectly defined in the set of regions instead of languages.
• String changes made/needed: None
• Is Android affected?: no

Comment 13

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Users of Saraiki (skr) builds will see the language displayed as [skr] in the accept-languages dialog. This is also triggering a warning in Web Console for Tor Browser, which is based on ESR branches.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: None
• Explanation of risk level: skr was incorrectly defined in the set of regions instead of languages.
• String changes made/needed: None
• Is Android affected?: no

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4634469671c

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/9c9f0a6ebb48