1911779 - "Include the address of the page I was on" is not ticked by default in Crash Reporter

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Brindusa Tot, DTE]

Found in

• Beta 130.0b1

Affected versions

• Nightly 131.0a1
• RC 129.0

Tested platforms

• Affected platforms: macOS 14, macOS 12 ARM, Windows 11, Ubuntu 24
• Unaffected platforms: -

Steps to reproduce

1. Launch Firefox, with a new profile.
2. Open one random page and then crash the browser with "about:crashparent".
3. Pay attention to the two checkboxes inside the crash reporter dialog

Expected result

• Both check boxes should be ticked by default.

Actual result

• The "Include the address of the page I was on." checkbox is NOT ticked by default.

Regression range

• Look for it asap

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=49f6b516c694f8b513f25f9b215da350f43d13ad&tochange=538aa6838630426342580bd8ea1330e0fcf3d56c

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1759175

:afranchuk, since you are the author of the regressor, bug 1759175, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Alex Franchuk [:afranchuk]]

This was an intentional change to be more conservative with personal information by default, however I'm okay with changing it back. :gsvelto thoughts?

Comment 4

[Gabriele Svelto [:gsvelto]]

Did we put the rationale for this decision in some bug?

Comment 5

[Alex Franchuk [:afranchuk]]

No. I originally did it because I thought that was the default (misinterpreting some code I read). A little later I realized my mistake but thought it might be better to stick with that. We can definitely change it back.

Comment 6

[Gabriele Svelto [:gsvelto]]

OK, let's check it by default. While digging around I found bug 1781087 which I had filed precisely to ensure that the default is to have it checked by default everywhere if the user never interacted with the field.

Comment 7

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1911779 - Default to including the URL in crash reports r=gsvelto

This default is used when the crash reporter has never been launched
before. Notably, this is currently a user-global setting (as opposed to
per-profile), so the defaults will typically only be used when someone
hasn't ever had Firefox installed on their system.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a7b709c7220
Default to including the URL in crash reports r=gsvelto

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0a7b709c7220

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:afranchuk, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Donal Meehan [:dmeehan]]

:afranchuk do you want to add an esr128 uplift request?

Comment 12

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1911779 - Default to including the URL in crash reports

This default is used when the crash reporter has never been launched
before. Notably, this is currently a user-global setting (as opposed to
per-profile), so the defaults will typically only be used when someone
hasn't ever had Firefox installed on their system.

Original Revision: https://phabricator.services.mozilla.com/D218887

Comment 13

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: None
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Very minimal
• Explanation of risk level: Merely changes a default setting in the crash reporter client.
• String changes made/needed: None
• Is Android affected?: no

Comment 14

[Alex Franchuk [:afranchuk]]

That's probably a good idea, just to encourage more information that may help to reproduce/diagnose/debug issues.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/3812db8185a4

Comment 16

[Brindusa Tot, DTE]

Verified as fixed on latest Nightly 131.0a1 and ESR 128.2.0esr build.