1911808 - New wpt failures in /css/css-backgrounds/parsing/background-image-computed.sub.html

Status: NEW

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 47477 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /css/css-backgrounds/parsing/background-image-computed.sub.html [wpt.fyi]
  • Property background-image value 'conic-gradient(red 0deg, gold 1turn)': FAIL

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1911720 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Daniel Holbert [:dholbert]]

Our failure is for this subtest:

test_computed_value('background-image',
  'conic-gradient(red 0deg, gold 1turn)',
  'conic-gradient(rgb(255, 0, 0) 0deg, rgb(255, 215, 0) 1turn)');

The failure is expressed like so:

assert_equals: expected
"conic-gradient(rgb(255, 0, 0) 0deg, rgb(255, 215, 0) 1turn)"
but got
"conic-gradient(rgb(255, 0, 0) 0deg, rgb(255, 215, 0) 360deg)"

We're just serializing the final angle as 360deg rather than 1turn (just differing units).

I'm not sure it makes sense for the test to be expecting units to be preserved (particularly when e.g. red is being converted to a rgb syntax which the test is expecting). Perhaps we should extend the test to at least allow our 360deg serialization for the final angle as well?