Open Bug 1911904 Opened 2 years ago Updated 5 days ago

High frequency browser/components/backup/tests/browser/browser_settings.js | single tracking bug

Categories

(Firefox :: Profile Backup, defect, P5)

Product:
Firefox
Component:
Profile Backup
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox129 --- unaffected
firefox130 --- unaffected
firefox131 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: handyman, NeedInfo)

References

(Regression)

Details

(4 keywords, Whiteboard: [stockwell disabled])

Attachments

(3 files)

Bug 1911904 - Disable browser_settings.js on linux tsan for frequent failures. r=#intermittent-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1911904: Clean up prefs in browser_password_validation_input.js and browser_settings.js tests r=#backup-reviewers!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1911904 - Restore syncPane spy after completing test_preferences_visibility test. r=#backup-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=469427110&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GIquUiHlQJiD-SAJOHeXnA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GIquUiHlQJiD-SAJOHeXnA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2024-08-06T21:33:25.515Z] 21:33:25     INFO - TEST-PASS | browser/components/backup/tests/browser/browser_settings.js | Filepicker shown - true == true - 
[task 2024-08-06T21:33:25.516Z] 21:33:25     INFO - Leaving test bound test_last_backup_info_and_location
[task 2024-08-06T21:33:25.516Z] 21:33:25     INFO - Buffered messages finished
[task 2024-08-06T21:33:25.516Z] 21:33:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/backup/tests/browser/browser_settings.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2024-08-06T21:33:25.517Z] 21:33:25     INFO - GECKO(4450) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2024-08-06T21:33:25.517Z] 21:33:25     INFO - GECKO(4450) | MEMORY STAT | vsize 16379MB | residentFast 386MB | heapAllocated 192MB
[task 2024-08-06T21:33:25.517Z] 21:33:25     INFO - TEST-OK | browser/components/backup/tests/browser/browser_settings.js | took 46297ms

:sthompson, since you are the author of the regressor, bug 1901308, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(sthompson)

Set release status flags based on info from the regressing bug 1901308

status-firefox129: --- → unaffected
status-firefox130: --- → unaffected
status-firefox131: --- → affected
status-firefox-esr115: --- → unaffected
status-firefox-esr128: --- → unaffected

Tier 1 failure link here.

Summary: Intermittent TV browser/components/backup/tests/browser/browser_settings.js | single tracking bug → Intermittent browser/components/backup/tests/browser/browser_settings.js | single tracking bug
Component: General → Profile Backup
Product: WebExtensions → Firefox

Retriggered and backfilled up to here

Summary: Intermittent browser/components/backup/tests/browser/browser_settings.js | single tracking bug → High-frequency browser/components/backup/tests/browser/browser_settings.js | single tracking bug

22 failures on trunk in the last 7 days

Whiteboard: [stockwell disable-recommended]
Whiteboard: [stockwell disable-recommended]
Assignee: nobody → smolnar
Status: NEW → ASSIGNED
Assignee: smolnar → nobody
Status: ASSIGNED → NEW
Keywords: leave-open
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7647cbb6a75a https://hg.mozilla.org/integration/autoland/rev/7da1f854aae5 Disable browser_settings.js on linux tsan for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Assignee: nobody → davidp99
Pushed by daparks@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3b0a2a03ac50 https://hg.mozilla.org/integration/autoland/rev/9e9ed407b772 Clean up prefs in browser_password_validation_input.js and browser_settings.js tests r=fchasen

Comment on attachment 9509920 [details]
Bug 1911904: Clean up prefs in browser_password_validation_input.js and browser_settings.js tests r=#backup-reviewers!

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a test-only patch that hasn't completely eliminated the intermittents but has reduced them a lot outside of ESR.
  • User impact if declined: None
  • Fix Landed on Version: 144
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's test-only
Attachment #9509920 - Flags: approval-mozilla-esr140?

Comment on attachment 9509920 [details]
Bug 1911904: Clean up prefs in browser_password_validation_input.js and browser_settings.js tests r=#backup-reviewers!

Of course, the day after I wrote that we suddenly see a massive spike in failures. It looks like ESR uplift may not make much difference after all. Back to the drawing board.

Attachment #9509920 - Flags: approval-mozilla-esr140?
Summary: High-frequency browser/components/backup/tests/browser/browser_settings.js | single tracking bug → Intermittent browser/components/backup/tests/browser/browser_settings.js | single tracking bug

I'd like to overhaul test_preferences_visiblity at some point (stubbing out
archiveEnabledStatus instead of twiddling prefs), but I think that bug
1996070 might need to be fixed first.

This assumes that the original reported issue in browser_settings is no
longer present, since this only appears to be a problem if the tests are
repeated, like in a verify run.

Pushed by dmcintosh@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3b803d1d3888 https://hg.mozilla.org/integration/autoland/rev/29ba8d00581a Restore syncPane spy after completing test_preferences_visibility test. r=fchasen
Flags: needinfo?(hsohaney)

Hi, could you take a look at this failure? It has over 200 failures in the last 30 days.
Failure log

[task 2026-05-20T18:27:22.812+00:00] 18:27:22     INFO - TEST-PASS | browser/components/backup/tests/browser/browser_settings.js | test_last_backup_info_and_location - Backup Dir Path was set - "C:\\Users\\task_177929851725255\\AppData\\Local\\Temp\\testLastBackupInfo" == true
[task 2026-05-20T18:27:22.813+00:00] 18:27:22     INFO - Buffered messages finished
[task 2026-05-20T18:27:22.813+00:00] 18:27:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/backup/tests/browser/browser_settings.js | test_last_backup_info_and_location - Uncaught exception in test - NotFoundError: Could not get children of `C:\Users\task_177929851725255\AppData\Local\Temp\testLastBackupInfo': directory does not exist (NS_ERROR_FILE_NOT_FOUND)
[task 2026-05-20T18:27:22.814+00:00] 18:27:22     INFO - Leaving test test_last_backup_info_and_location
[task 2026-05-20T18:27:22.815+00:00] 18:27:22     INFO - Entering test test_dialogs_close_on_cancel_with_restore_disabled
[task 2026-05-20T18:27:22.835+00:00] 18:27:22     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 1fb2b3af000 == 9 [pid = 8064] [id = 17]
[task 2026-05-20T18:27:22.844+00:00] 18:27:22     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 37 (1fb1edc5400) [pid = 8064] [serial = 41] [outer = 0]
[task 2026-05-20T18:27:22.845+00:00] 18:27:22     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 38 (1fb301ae000) [pid = 8064] [serial = 42] [outer = 1fb1edc5400]
[task 2026-05-20T18:27:22.937+00:00] 18:27:22     INFO - GECKO(2036) | [Parent 8064, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x804B000A (NS_ERROR_MALFORMED_URI): file checkouts\gecko\dom\base\Document.cpp:17855
[task 2026-05-20T18:27:22.941+00:00] 18:27:22     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 39 (1fb18a8b600) [pid = 8064] [serial = 43] [outer = 1fb1edc5400]
[task 2026-05-20T18:27:23.527+00:00] 18:27:23     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 1fb1c823c00 == 10 [pid = 8064] [id = 18]
[task 2026-05-20T18:27:23.530+00:00] 18:27:23     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 40 (1fb278e3900) [pid = 8064] [serial = 44] [outer = 0]
[task 2026-05-20T18:27:23.531+00:00] 18:27:23     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 41 (1fb17be6100) [pid = 8064] [serial = 45] [outer = 1fb278e3900]
[task 2026-05-20T18:27:23.541+00:00] 18:27:23     INFO - GECKO(2036) | [Parent 8064, Main Thread] WARNING: NS_ENSURE_TRUE(entry && entry->mInfo->mSharedState.Get()) failed: file checkouts\gecko\docshell\shistory\SessionHistoryEntry.cpp:1147
[task 2026-05-20T18:27:24.380+00:00] 18:27:24     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/SlowChromeEvent Please do not use mouseenter/leave events in chrome. They are slower than mouseover/out! chrome://global/content/vendor/lit.all.mjs line 22 > importedModule:2024:26
[task 2026-05-20T18:27:24.725+00:00] 18:27:24     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 40 (1fb1ed8a200) [pid = 8064] [serial = 32] [outer = 0] [url = about:blank]
[task 2026-05-20T18:27:24.727+00:00] 18:27:24     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 39 (1fb2aee1000) [pid = 8064] [serial = 22] [outer = 0] [url = about:blank]
[task 2026-05-20T18:27:24.728+00:00] 18:27:24     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 38 (1fb2ae37c00) [pid = 8064] [serial = 17] [outer = 0] [url = about:blank]
[task 2026-05-20T18:27:24.728+00:00] 18:27:24     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 37 (1fb27830100) [pid = 8064] [serial = 12] [outer = 0] [url = about:blank]
[task 2026-05-20T18:27:24.730+00:00] 18:27:24     INFO - GECKO(2036) | [Parent 8064: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 36 (1fb2782f700) [pid = 8064] [serial = 27] [outer = 0] [url = about:blank]
[task 2026-05-20T18:27:24.967+00:00] 18:27:24     INFO - TEST-PASS | browser/components/backup/tests/browser/browser_settings.js | test_dialogs_close_on_cancel_with_restore_disabled - disable-backup-encryption-dialog was opened.
[task 2026-05-20T18:27:24.998+00:00] 18:27:24     INFO - TEST-PASS | browser/components/backup/tests/browser/browser_settings.js | test_dialogs_close_on_cancel_with_restore_disabled - disable-backup-encryption-dialog was closed by dialogCancel.
Flags: needinfo?(mconley)
Summary: Intermittent browser/components/backup/tests/browser/browser_settings.js | single tracking bug → High frequency browser/components/backup/tests/browser/browser_settings.js | single tracking bug
Duplicate of this bug: 2042230
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: