1912022 - Fix _execute_browser_action command in menus API

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

Found to be not working while investigating bug 1911752.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1912022 - Fix _execute_browser_action command in menus API. r=#thunderbird-reviewers

Found to be not working while investigating bug 1911752. Will add a
dedicated test for this in bug 1912021.

This seems to be a left-over from the time when the mail tab was split
into sub windows (or it never worked). A mouse click event on the folder
pane or message pane is passing the about:3pane window and the
detection code for the unified toolbar (see 1) fails. The action is
therefore not triggered.

Depends on D218622

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/18cd1b44d498
Fix _execute_browser_action command in menus API. r=aleca

Comment 3

[John Bieling (:TbSync)]

Comment on attachment 9418112 [details]
Bug 1912022 - Fix _execute_browser_action command in menus API. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): MailTab redisign in 115
User impact if declined: Using _execute action in the menus API do not work
Testing completed (on c-c, etc.): some days on c-c
Risk to taking this patch (and alternatives if risky): Low, we are just using the correct target window

Comment 4

[John Bieling (:TbSync)]

Comment on attachment 9418112 [details]
Bug 1912022 - Fix _execute_browser_action command in menus API. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): MailTab redisign in 115
User impact if declined: Using _execute action in the menus API do not work
Testing completed (on c-c, etc.): some days on c-c
Risk to taking this patch (and alternatives if risky): Low, we are just using the correct target window

Comment 5

[Corey Bryant]

Comment on attachment 9418112 [details]
Bug 1912022 - Fix _execute_browser_action command in menus API. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 130.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5fbd21760318

Comment 7

[Corey Bryant]

John, I didn't see an uplift request for esr128, but I'm fairly certain you intended to add it. Please let me know if not. Thanks.

Comment 8

[Corey Bryant]

Comment on attachment 9418112 [details]
Bug 1912022 - Fix _execute_browser_action command in menus API. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115
Approved for esr128

Comment 9

[John Bieling (:TbSync)]

Hi Corey, my intention was to request uplift to 128, not 115. I probably was still used to request uplifts to ESR = 115 :-)

If you think uplift to 115 is fine, I will take that as well. Thanks!

Comment 10

[Corey Bryant]

Let's include it then. Going forward I'd prefer to only uplift high impact and security fixes to esr115. Thanks John.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 128.2.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/20715e5d6d95

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 115.15.0:
https://hg.mozilla.org/releases/comm-esr115/rev/afc470ec4bdc