1912053 - Console error when toolbar overflows

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Henry Wilkes (they/them) [:henry-x]]

Overview

Steps to reproduce

1. Open firefox.
2. Make the window narrow until the firefox account item overflows.

Result

Console error

CustomizableUI: TypeError: can't access property "localName", aNode is null -- resource:///modules/CustomizableUI.sys.mjs:1746

And again when expanding the window width.

Expect

No error

Origin

I think this comes from this line which will pass in null to isWebExtensionWidget because the widget-id attribute is not set.

Comment 1

[William Durand [:willdurand]]

I'd be surprised if this was a regression from Bug 1800417 but maybe. Did you confirm with mozregression or an older version than Firefox 112?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800417

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

I did not confirm with mozregression. I couldn't reproduce in 115 because getAttribute() returns "" rather than null (for only XUL). Not sure which bug introduced that change to XUL though. It was bug 232598.

I chose bug 1800417 because that introduced passing in the widget-id attribute to isWebExtensionWidget, even when the attribute didn't exist, which seemed like a bug in the initial implementation. But I guess the XUL change brought it out.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

While we are happy to take a fix, I'm marking this fix-optional in order to remove it from weekly triage, because the severity and priority is low.

Comment 5

[:Gijs (he/him)]

I can't reproduce. Are you still seeing this - perhaps it got fixed?

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

(In reply to :Gijs (he/him) from comment #5)

I can't reproduce. Are you still seeing this - perhaps it got fixed?

I think it was probably fixed by bug 1899346, which took the null cases into account (https://hg-edge.mozilla.org/mozilla-central/rev/b50071da8b63#l2.859 and https://hg-edge.mozilla.org/mozilla-central/rev/b50071da8b63#l2.241).