Closed Bug 1912131 Opened 4 months ago Closed 3 months ago

Update minidump-writer to 0.10.0

Categories

(Toolkit :: Crash Reporting, task)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: afranchuk, Assigned: afranchuk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

minidump_writer needs to be updated to at least 0.9.0, however we need a new release to at least incorporate the fix in https://github.com/rust-minidump/minidump-writer/pull/129.

Depends on: 1831056
Summary: Update minidump_writer to 0.9.1 → Update minidump-writer to 0.9.1
Blocks: 1831056
No longer depends on: 1831056
Summary: Update minidump-writer to 0.9.1 → Update minidump-writer to 0.10.0

This is using a git rev for now as a new version hasn't been released
yet.

Assignee: nobody → afranchuk
Status: NEW → ASSIGNED
Pushed by afranchuk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ff7570a00ed Update minidump-writer to 0.10.1 r=gsvelto,glandium,supply-chain-reviewers

Backed out for causing NonZero related build bustage

Backout link

Push with failures

Failure log

Flags: needinfo?(afranchuk)

Hmm, not sure what's going on there. I built successfully before trying to land (linux x64), and just tried again. I found that I had to rebase on autoland because of conflicts originally. I guess I'll throw it at try, or just wait to be able to rebase on central on Monday and hope for better results.

Flags: needinfo?(afranchuk)

Oh, I see now, it's a minimum rust version issue. The crate is using generic NonZero, which is since 1.79.0. I didn't pick up on that subtle detail because I knew other NonZero types have been around for a while.

https://github.com/rust-minidump/minidump-writer/pull/136

:gsvelto we want to get that PR in too. At this point Jake may be back and able to make a release.

Flags: needinfo?(gsvelto)
Pushed by afranchuk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/722757cefe01 Update minidump-writer to 0.10.1 r=gsvelto,glandium,supply-chain-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Flags: needinfo?(gsvelto)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: