1912193 - Diagram "Limits Hit" results should show pretty symbols and support a mechanism for re-writing the query to lift the limit

Status: ASSIGNED

(Webtools :: Searchfox, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

An example automatic diagram query of calls-to:'mozilla::dom::ContentParent::ValidatePrincipal' depth:4 displays the currently inscrutable limit of:

• _ZN7mozilla3dom13ContentParent17ValidatePrincipalEP12nsIPrincipalRKNS_7EnumSetINS1_24ValidatePrincipalOptionsEjEE: UsesLines: 23 exist, 0 included. Local limit: 16

This of course was not the long-term plan, just the simplest way to make it clear when heuristics are explicitly not expanding something so people can know what parts of the diagram not to trust.

The general roadmap for improving this functionality as envisioned has been:

1. Show the actual pretty identifier for the symbol.
2. Add an option to raise the limit from the "Limits Hit" list.
3. Visually display on the diagram the symbols that have been impacted by a limit being hit, potentially injecting synthetic aggregation nodes.
4. Make it possible to perform the same limit raising from the visual display on the diagram as is exposed from the "Limits Hit" list.
5. Expand on the visual display of overloads by creating collapsed/rolled-up faceted nodes that allow expansion/inclusion of only some of the matches, such as those within the same subsystem. This of course would interact with other heuristic-based approaches that are aware of subsystem boundaries, etc.

I'll probably hack on the simplest approach over the MozWeek and surrounding PTO as I try and finish up a blog post on automatic searchfox diagrams.