1912272 - Add more helpers to QuotaManagerDependencyFixture

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

Add more helpers to QuotaManagerDependencyFixture.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Gettting cached origin usage shouldn't trigger temporary storage initialization; r=#dom-storage

Currently, getting cached origin usage may trigger temporary storage
initialization which is a problem in tests when we want just compare real and
cached usage without affecting the state of initialization.

This patch changes the behavior to return Nothing if temporary storage is not
initialized.

Consumers may either explicitly make sure that temporary storage is initialized
before getting cached origin usage or they can use the other mode when real
usage is colleced from disk.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Add Await convenience method to QuotaManagerDependencyFixture; r=#dom-storage

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Add more helpers to QuotaManagerDependencyFixture; r=#dom-storage

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Change GetOriginUsage to always require non-null output argument; r=#dom-storage

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Add QuotaManagerDependencyFixture::GetCachedOriginUsage; r=#dom-storage

There are plans to add nsIQuotaManagerService::getCachedUsageForPrincipal and
then remove the aFromMemory argument from
nsIQuotaManagerService::getUsageForPrincipal, so this patch adds a testing
method in that sense.

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Add support for returning values from PerformOnThread functions; r=#dom-storage

The return value is deduced from the performed function.

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1912272 - Introduce ENSURE_NO_FATAL_FAILURE macro; r=#dom-storage

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f795a7822089
Add Await convenience method to QuotaManagerDependencyFixture; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/6a46455a6060
Add more helpers to QuotaManagerDependencyFixture; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/2008800c7ecb
Gettting cached origin usage shouldn't trigger temporary storage initialization; r=hsingh
https://hg.mozilla.org/integration/autoland/rev/de34394ce390
Change GetOriginUsage to always require non-null output argument; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/5ef242e1c4f9
Add QuotaManagerDependencyFixture::GetCachedOriginUsage; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/abe159f8800d
Add support for returning values from PerformOnThread functions; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/5619d371ada1
Introduce ENSURE_NO_FATAL_FAILURE macro; r=dom-storage-reviewers,jari

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f795a7822089
https://hg.mozilla.org/mozilla-central/rev/6a46455a6060
https://hg.mozilla.org/mozilla-central/rev/2008800c7ecb
https://hg.mozilla.org/mozilla-central/rev/de34394ce390
https://hg.mozilla.org/mozilla-central/rev/5ef242e1c4f9
https://hg.mozilla.org/mozilla-central/rev/abe159f8800d
https://hg.mozilla.org/mozilla-central/rev/5619d371ada1