1912285 - Empty computed value isn't displayed in variable tooltip

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to data:text/html,<meta charset=utf8><style>body { --a: var(--b); --b: ; color: var(--a);}</style>Hello
2. Open the inspector
3. Hover --a in the color declaration

Expected results

There is a "computed value" section in the tooltip, with an empty value

Actual results

There is no "computed value" section

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1912285 - [devtools] Display empty computed value in var tooltip. r=#devtools-reviewers.

The #createNode function wasn't adding attribute if they
were empty, meaning that the data-variable-computed attribute
wouldn't be set for empty computed value (which are stil valid).

Note that this doesn't look great in the tooltip at the moment,
we may display empty values differently in Bug 1912267.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37e81da12248
[devtools] Display empty computed value in var tooltip. r=devtools-reviewers,jdescottes.

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/37e81da12248