1912820 - [wpt-sync] Sync PR 47571 - [calc-size] Fix grid intrinsic repeat calculation.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47571 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47571
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[calc-size] Fix grid intrinsic repeat calculation.

Previously during the min/max sizes pass we returned
border/scrollbar/padding as the min-content/max-content sizes for
calculating how many repeaters we have.

This was ~fine, but now with calc-size() we can perform calculations
based on this. This would result in a incorrect calculation (as
demonstrated by the testcase).

Return kIndefiniteSize instead.

Bug: 313072
Change-Id: I4efa890f4ad5ff4df3e4c2f682cd8b49681c7d64

Reviewed-on: https://chromium-review.googlesource.com/5778346
WPT-Export-Revision: 38d5882ee0cfedd96dee6325ca0670f48cd46dee

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1910a76758010f24debd48484215d269431e348e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/456ba5d5675f
[wpt PR 47571] - [calc-size] Fix grid intrinsic repeat calculation., a=testonly

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/456ba5d5675f