1913053 - When folder(s) and/or bookmark(s) in the sidebar are selected and have focus, the background color of the items turns light gray (#F0F0F0), while the text color turns white, making it almost impossible to see the text when using the Light theme.

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[CKOTTMozillaBugzilla]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

Right-click on a folder or bookmark in the sidebar to select it.

Actual results:

The folder/bookmark name text turns white, and the text background turns light gray (#F0F0F0), which makes it almost impossible to see the text when using the Light theme.

Expected results:

The text background should turn a darker color, with sufficient contrast to make the white text easy to read. Previous versions of Firefox used a shade of blue for the text background.

I just verified that, using Firefox 127.0 64-bit, the text turns white, but the background turns blue (#0078D7).

Note: This only happens in the sidebar. When using the Library, the text background still turns blue (#0078D7).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[CKOTTMozillaBugzilla]

I just tested v.128 and v.129 of Firefox (release), and the background color is still blue, so it seems that v.130 is the first version to be affected.

Comment 3

[Alice0775 White]

I can reproduce the issue with Light theme.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=47c985c18cb2e719b3cf98514919334be882c9e7&tochange=cad076214b85f9e1f93c1826b52455d26b797966

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:nsharpley, since you are the author of the regressor, bug 1886847, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Nikki Sharpley (:nikkis) (she/her)]

Thanks for reporting! Working on a fix.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1913053 - Use the sidebar text color along with the fallback background on selected rows for themes not setting highlight colors. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b7336d4bb14
Use the sidebar text color along with the fallback background on selected rows for themes not setting highlight colors. r=nsharpley,emilio,desktop-theme-reviewers

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9b7336d4bb14

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 9419223 [details]
Bug 1913053 - Use the sidebar text color along with the fallback background on selected rows for themes not setting highlight colors. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: please see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fairly straightforward CSS-only fix
• String changes made/needed:
• Is Android affected?: No

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9419223 [details]
Bug 1913053 - Use the sidebar text color along with the fallback background on selected rows for themes not setting highlight colors. r=emilio

Approved for 130.0b7.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b0532795d1c

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 131.0a1 (2024-08-13) on macOS 14.6.1 by following the STR from Comment 0.

The issue is fixed on Firefox 131.0a1 (2024-08-19). Tests were performed on macOS 14.6.1, Windows 11 and Ubuntu 24.04.

Will verify on 130.0b7 once it is available on treeherder.

Comment 14

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the issue is fixed as well on Firefox 130.0b7 (treeherder build). Tests were performed on macOS 14.6.1, Windows 11 and Ubuntu 24.04.