Closed Bug 1913194 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 47605 - Add tests for unitless 0 being invalid in calc-size().

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47605 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47605
Details from upstream follow.

David Baron <dbaron@chromium.org> wrote:

Add tests for unitless 0 being invalid in calc-size().

See https://github.com/w3c/csswg-drafts/issues/10354

Bug: 341564374, 313072
Change-Id: Ie0e03b82812b0f7748aaa5f892c60347bcf996e0
Reviewed-on: https://chromium-review.googlesource.com/5788112
WPT-Export-Revision: 3b60ea6847706dd49a5dec7e3fd5bd6bdad8bdbc

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 93 subtests

Status Summary

Firefox

OK : 1
PASS: 56
FAIL: 37

Chrome

OK : 1
PASS: 87
FAIL: 6

Safari

OK : 1
PASS: 56
FAIL: 37

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-values/calc-size/calc-size-parsing.html [wpt.fyi]
    • e.style['width'] = "calc-size(auto, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['min-width'] = "calc-size(auto, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['height'] = "calc-size(auto, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['min-height'] = "calc-size(auto, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['height'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['max-width'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['max-height'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['min-width'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['min-height'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['block-size'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['inline-size'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['max-block-size'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['max-inline-size'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['min-block-size'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['min-inline-size'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(fit-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['height'] = "calc-size(min-content, size * 2)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['max-width'] = "calc-size(max-content, size / 2)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['max-height'] = "calc-size(fit-content, 30px + size / 2)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(fit-content, 50% + size / 2)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(any, 25em)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(any, 40%)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(any, 50px + 30%)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(10px, sign(size) * size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(30px, 25em)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(calc-size(any, 30px), 25em)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(calc-size(2in, 30px), 25em)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(calc-size(min-content, 30px), 25em)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(calc-size(min-content, size), size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['flex-basis'] = "calc-size(any, 50px)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['flex-basis'] = "calc-size(auto, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['flex-basis'] = "calc-size(min-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['flex-basis'] = "calc-size(max-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['flex-basis'] = "calc-size(fit-content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['flex-basis'] = "calc-size(content, size)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['width'] = "calc-size(0px, 0px)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9fe9b595437 [wpt PR 47605] - Add tests for unitless 0 being invalid in calc-size()., a=testonly https://hg.mozilla.org/integration/autoland/rev/ed2714108399 [wpt PR 47605] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c9fe9b595437
https://hg.mozilla.org/mozilla-central/rev/ed2714108399

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.