1913224 - After repairing an IMAP folder, total/unread message counts are displayed incorrectly

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Open the properties of an IMAP folder that is not currently selected.
2. Repair the folder.

Expected result:
Message counts are reset to 0 and increase while the message headers are downloaded.

Actual result:
Message counts are not reset and are show a multiple of the actual counts after repairing.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

In Daily (with bug 1910168 fixed) the same happens also when repairing the currently selected folder.

Another observation that may be a regression of the referenced bug:

Repairing an IMAP folder after deleting some of its messages may result in the following log being displayed in the console multiple times:

gloda.index_msg: Exception while attempting to mark message with gloda state afterdb commit NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBHdr.getUint32Property]
    _commitCallback resource:///modules/gloda/IndexMsg.sys.mjs:144
    handleCompletion resource:///modules/gloda/GlodaDatastore.sys.mjs:61
    editFolder chrome://messenger/content/about3Pane.js:3423
    <anonymous> chrome://messenger/content/about3Pane.js:6296
    doCommand chrome://messenger/content/mailCommon.js:736
    triggerCommand chrome://messenger/content/about3Pane.js:867
    onCommand chrome://messenger/content/about3Pane.js:851
    handleEvent chrome://messenger/content/about3Pane.js:326

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1913224 - Reset certain properties when repairing an IMAP folder. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/160fb8d4126e
Reset certain properties when repairing an IMAP folder. r=mkmelin

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9419183 [details]
Bug 1913224 - Reset certain properties when repairing an IMAP folder. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 550286
User impact if declined: After repairing an IMAP folder, total/unread message counts are displayed incorrectly
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): fairly low

Comment 5

[Corey Bryant]

Comment on attachment 9419183 [details]
Bug 1913224 - Reset certain properties when repairing an IMAP folder. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/c83c7cc8478e

Comment 7

[Magnus Melin [:mkmelin]]

This is causing comm/mail/base/test/browser/browser_repairFolder.js failures (and failing functionality) - https://treeherder.mozilla.org/jobs?repo=comm-esr128&selectedTaskRun=FC31dvCeQ0K0kvQmU1al7A.0 - uplifting bug 1904799 should fix that.

Comment 8

[Corey Bryant]

We've picked up the bug 1904799 uplift in today's build. Thanks Magnus.