1913401 - Shift and menu Edit | "Delete selected messages" does a normal "move to Trash" delete. There is no prompt that delete is immediate and no save to Trash

Status: RESOLVED DUPLICATE of bug 393523

(Thunderbird :: Folder and Message Lists, defect)

Description

[gene smith]

If one or more than one message is selected and with Shift key pressed and,

• Menu item "Edit | Delete selected messages" selected, or
• "Delete" button above the preview pane is clicked,

then there is no prompt to warn that the delete will be immediate and not saved to Trash. Instead a normal "move to Trash" deletion occurs.
However, with just one message selected, if the "Delete" button above preview pane is clicked with shift held down, the expected prompt does occur.

Also, if one or more than one message is selected with Shift key pressed and,

• Right click to bring up message context menu and "Trash" icon is clicked, or
• "Delete" key on keyboard is pressed

then the expected prompt does occur to warn that the delete will be immediate and not saved to Trash. Looks like this was fixed for context menu here: bug 956446.

I noticed this on a self-built daily 129.0a1 (not the latest) and with 128.1.0esr. This may be fixed on c-c tip but I haven't tested with that but couldn't find a bug report about this.

Expected result:
In all cases with shift key held down, how ever "delete" is triggered (menu, context icon, button, or keyboard del key), the prompt should occur that the delete will be immediate and bypass the Trash folder for the selected message(s).

I noticed this while working on bug 399475.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1913401 - Enable shift-delete in multi message view. r=#thunderbird-reviewers

Comment 2

[Hartmut Welpmann [:welpy-cw]]

While I think this should work for the delete button in multi message view exactly as for that in message header view (and is easy to fix), I am not so sure about the "Delete selected messages" item under the menu bar. Does anyone really use that workflow? Anyway, to fix it there as well appears to be much more complicated, since the exact menu item is used for other delete tasks (such as folders) as well.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1913401 - Enable shift-delete in messages menu under menu bar. r=#thunderbird-reviewers

Comment 4

[gene smith]

Does anyone really use that workflow?

I never do but for consistency it should probably treat shift key like the other "delete message(s)" ways.
Anyhow, the comment 1 and comment 3 patch (both applied) work for me and completely fixes this bug report.
Thanks!

Comment 5

[Hartmut Welpmann [:welpy-cw]]

This is being addressed now in bug 393523.

Comment 6

[gene smith]

Since this was fixed at bug 393523, I'm closing this as dupe of that bug.