Closed Bug 1913410 Opened 8 months ago Closed 8 months ago

[wpt-sync] Sync PR 47637 - shape-outside: Fix incorrect box margin computation

Categories

(Core :: Layout: Floats, task, P4)

task

Tracking

()

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47637 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47637
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

shape-outside: Fix incorrect box margin computation

GetShapeImageMarginRect() returns a logical rectangle in the box's
writing-mode. It should be its container's writing-mode.

This CL adds a function returning a physical margin rectangle, and
we should handle writing-mode in ExtractIntervalsFromImageData().

Bug: 360158400
Change-Id: Ide86b99073bf9d2bea912e1139d02713ed9d9785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786284
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Auto-Submit: Kent Tamura \<tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342665}

Component: web-platform-tests → Layout: Floats
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b3c612107d9 [wpt PR 47637] - shape-outside: Fix incorrect box margin computation, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.