Closed Bug 19135 Opened 25 years ago Closed 25 years ago

[dogfood] XIM hack break Editor Txn Undo/Redo

Categories

(Core :: Internationalization, defect, P3)

Product:
Core
Component:
Internationalization
Platform:
Other
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: ftang, Assigned: ftang)

Details

(Keywords: inputmethod, Whiteboard: [PDT-]) 

In http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsGtkEventHandler.cpp
764 gint handle_key_press_event(GtkObject *w, GdkEventKey* event, gpointer p)
801     if (decoder && (!kevent.keyCode)) {
802       nsEventStatus status;
803       composition_start(event, win, &status);
804       composition_draw(event, win, decoder, &status);
805       composition_end(event, win, &status);
806     } else {
807       InitKeyPressEvent(event,p, kevent);
808       win->OnKey(kevent);
809       nsEventStatus status;
810       composition_start(event, win, &status);
811       composition_end(event, win, &status);

the line 810 and 811 will generate Composition start and end event for every key
pressed and cause the Text Txn in Editor not merge. This break editor undo/redo
in Linux.
Hardware: PC → Other
Summary: XIM hack break Editor Txn Undo/Redo → [dogfood] XIM hack break Editor Txn Undo/Redo
Whiteboard: [PDT-]
Undo is not engineering dogfood.  Putting on PDT- radar.
Assignee: tajima → ftang
Fixed a while ago by ftang.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
QA Contact: teruko → ftang
fix
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.