Closed Bug 1913624 Opened 1 year ago Closed 1 year ago

Remove expired legacy telemetry histograms definitions and their code

Categories

(Toolkit :: Telemetry, task)

task

Tracking

()

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(50 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

The data stopped being sent to servers when the probes expired, so the remaining code is dead in the best case, and causing pointless overhead in the worst case.

Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7106294fa801 Remove expired telemetry histogram QUIRKS_MODE, r=chutten. https://hg.mozilla.org/integration/autoland/rev/03d71dfeca8c Remove expired telemetry histogram URLCLASSIFIER_VLPS_LONG_PREFIXES, r=chutten. https://hg.mozilla.org/integration/autoland/rev/6b5d7422efb1 Remove expired telemetry histograms PERMISSION_REQUEST_ORIGIN_SCHEME and PERMISSION_REQUEST_HANDLING_USER_INPUT, r=chutten,firefox-desktop-core-reviewers . https://hg.mozilla.org/integration/autoland/rev/0ac6b204681d Remove expired telemetry histograms HTTP_AUTH_DIALOG_STATS_3 and HTTP_AUTH_TYPE_STATS, r=chutten,necko-reviewers,kershaw. https://hg.mozilla.org/integration/autoland/rev/dc0744319874 Remove expired telemetry histogram TAB_AUDIO_INDICATOR_USED, r=chutten,tabbrowser-reviewers,dao. https://hg.mozilla.org/integration/autoland/rev/1a1f0545e96e Remove expired telemetry histogram HOVER_UNTIL_UNSELECTED_TAB_OPENED, r=chutten,tabbrowser-reviewers,dao. https://hg.mozilla.org/integration/autoland/rev/b93afd77581d Remove expired telemetry histogram AUTOPLAY_DEFAULT_SETTING_CHANGE, r=chutten,firefox-desktop-core-reviewers . https://hg.mozilla.org/integration/autoland/rev/5f8e78017d12 Remove expired telemetry histograms ENCODING_OVERRIDE_SITUATION_TEXT and ENCODING_OVERRIDE_SITUATION_HTML, r=chutten. https://hg.mozilla.org/integration/autoland/rev/5c83d2db6d25 Remove expired telemetry histograms LOCALDOMSTORAGE_*_BLOCKING_MS, r=chutten. https://hg.mozilla.org/integration/autoland/rev/4c32f52b15ae Remove expired telemetry histogram SERVICE_WORKER_CONTROLLED_DOCUMENTS, r=chutten. https://hg.mozilla.org/integration/autoland/rev/7a31cb738c7a Remove expired telemetry histogram SERVICE_WORKER_UPDATED, r=chutten. https://hg.mozilla.org/integration/autoland/rev/bc0d2da3e459 Remove expired telemetry histograms SERVICE_WORKER_SPAWN_ATTEMPTS and SERVICE_WORKER_WAS_SPAWNED, r=chutten. https://hg.mozilla.org/integration/autoland/rev/4bc6b98f65f3 Remove expired telemetry histograms VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE, VIDEO_INTER_KEYFRAME_AVERAGE_MS and VIDEO_INTER_KEYFRAME_MAX_MS, r=chutten,webidl,emilio. https://hg.mozilla.org/integration/autoland/rev/e3485b19ffd5 Remove expired telemetry histograms ENCODING_DETECTION_OUTCOME_TEXT and ENCODING_DETECTION_OUTCOME_HTML, r=chutten.
Keywords: leave-open
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fb6627ad9a2 Remove expired telemetry histograms INPUT_EVENT_RESPONSE_{STARTUP,POST_STARTUP}_MS, INPUT_EVENT_QUEUED_APZ_{TOUCH_MOVE,MOUSE_MOVE,WHEEL_MS} and INPUT_EVENT_HANDLED_*_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/bc7eccc9c3a7 Remove expired telemetry histograms TIME_TO_FIRST_CLICK_MS, TIME_TO_FIRST_KEY_INPUT_MS, TIME_TO_FIRST_MOUSE_MOVE_MS and TIME_TO_FIRST_SCROLL_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/37416d7bfc60 Remove expired telemetry histograms TIME_TO_NON_BLANK_PAINT_NETOPT_MS, TIME_TO_NON_BLANK_PAINT_NO_NETOPT_MS and TIME_TO_{DOM_CONTENT_LOADED,LOAD_EVENT}_START_{ACTIVE_NETOPT,ACTIVE}_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/43c7fa19e253 Remove expired telemetry histograms DOM_SCRIPT_KIND and DOM_SCRIPT_PRELOAD_RESULT, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/0efd9d5ede70 Remove expired telemetry histograms SANDBOX_HAS_SECCOMP_BPF, SANDBOX_HAS_SECCOMP_TSYNC, SANDBOX_HAS_USER_NAMESPACES_PRIVILEGED, SANDBOX_MEDIA_ENABLED and SANDBOX_CONTENT_ENABLED, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/54e5d0bcfefc Remove expired telemetry histogram THREAD_WAKEUP, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/7a9af768f395 Remove expired telemetry histogram TELEMETRY_ASSEMBLE_PAYLOAD_EXCEPTION, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/5d046172ff63 Remove expired telemetry histograms PRINT_BACKGROUND_TASK_TIME_MS and PRINT_BACKGROUND_TASK_ROUND_TRIP_TIME_MS, r=win-reviewers,gstoll,TravisLong. https://hg.mozilla.org/integration/autoland/rev/252cb1163c49 Remove expired telemetry histograms PRINT_INIT_TO_PLATFORM_SENT_SETTINGS_MS and PRINT_INIT_TO_PREVIEW_DOC_SHOWN_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/37133868c0ae Remove expired telemetry histograms NARRATE_CONTENT_BY_LANGUAGE_2 and NARRATE_CONTENT_SPEAKTIME_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/34f3f29ec922 Remove expired telemetry histogram GRAPHICS_SANITY_TEST_REASON, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/248a2a08cf7d Remove expired telemetry histogram ALERTS_SERVICE_DND_ENABLED, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/08dd9442e848 Remove expired telemetry histogram WEAVE_WIPE_SERVER_SUCCEEDED, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/5a0bf1423b84 Remove expired telemetry histogram PRESSHELL_LAYOUT_TOTAL_MS_PER_TICK, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/418c7f122235 Remove expired telemetry histograms IPC_MESSAGE_SIZE2, IPC_REPLY_SIZE, IPC_SYNC_MAIN_LATENCY_MS and IPC_SYNC_RECEIVE_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/bb527a25e376 Remove expired telemetry histogram D3D11_SYNC_HANDLE_FAILURE, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/aab1566fbec5 Remove expired telemetry histogram GPU_WAIT_TIME_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/2938dcb50df3 Remove expired telemetry histogram MIXED_CONTENT_DOWNLOADS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/7f324c519dcc Remove expired telemetry histogram WEB_AUDIO_BECOMES_AUDIBLE_TIME, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/64af10088a89 Remove expired telemetry histogram WEB_AUDIO_AUTOPLAY, r=media-playback-reviewers,TravisLong,alwu.
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8d435d3eb99 Remove expired telemetry histogram MEDIA_RECORDER_RECORDING_DURATION, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/0bcfc69d733b Remove expired telemetry histogram VIDEO_SUSPEND_RECOVERY_TIME_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/2d0d2a30a710 Remove expired telemetry histogram MEDIA_MKV_CANPLAY_REQUESTED, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/4b91d3f5b94b Remove expired telemetry histogram TABCHILD_PAINT_TIME, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/37610f67549a Remove expired telemetry histograms IPC_SAME_PROCESS_MESSAGE_COPY_OOM_KB and IPC_SYNC_MESSAGE_MANAGER_LATENCY_MS, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/9bc0f3b04005 Remove expired telemetry histogram FX_SESSION_RESTORE_PRIVACY_LEVEL, r=sessionstore-reviewers,TravisLong,dao. https://hg.mozilla.org/integration/autoland/rev/3814355c5b37 Remove expired telemetry histogram FX_TABLETMODE_PAGE_LOAD, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/c5e57fa0e2f2 Remove expired telemetry histogram A11Y_UIA_DETECTION_TIMING_MS, r=TravisLong.
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d399f51f0aa Remove expired telemetry histograms HTTP_CACHE_IO_*, r=chutten,necko-reviewers,kershaw. https://hg.mozilla.org/integration/autoland/rev/963e3d7f43ff Remove expired telemetry histograms HTTP_NET_VS_CACHE_*_V2, r=chutten,necko-reviewers,TravisLong,kershaw. https://hg.mozilla.org/integration/autoland/rev/6ba3bd9947a7 Remove expired telemetry histogram HTTP_CHILD_OMT_STATS_2, r=necko-reviewers,TravisLong,kershaw. https://hg.mozilla.org/integration/autoland/rev/75ac0218ebcf Remove expired telemetry histogram NETWORK_CONNECTION_COUNT, r=TravisLong. https://hg.mozilla.org/integration/autoland/rev/7039ddfea5aa Remove expired telemetry histogram NETWORK_COOKIE_UNICODE_BYTE, r=TravisLong,valentin.
Keywords: leave-open
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68129e5d160e Remove expired telemetry histogram MEDIA_GMP_UPDATE_CONTENT_PROCESS_HAS_H264, r=TravisLong,aosmond. https://hg.mozilla.org/integration/autoland/rev/f3018cd0c27c Remove expired telemetry histogram FX_TAB_SWITCH_REQUEST_TAB_WARMING_STATE, r=TravisLong,mconley. https://hg.mozilla.org/integration/autoland/rev/d22b13eb4f78 Remove expired telemetry histogram TABS_AUDIO_COMPETITION, r=media-playback-reviewers,TravisLong,alwu.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch

diffstat of the 50 patches that landed here: 94 files changed, 55 insertions(+), 3074 deletions(-)

See Also: → 1915228
Regressions: 1916854
Blocks: 1841927
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: