1913656 - MOZ_OPTIMIZE is always 1 even with --disable-optimize

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tooru Fujisawa [:arai]]

MOZ_OPTIMIZE is set to "1" depending on MOZ_OPTIMIZE_FLAGS environment variable, where the condition env_flags becomes truthy if the environment variable has any value, including empty string, given the value is represented as a tuple ("",).

https://searchfox.org/mozilla-central/rev/53e68046298557fae0c922230b595bb6689bf587/build/moz.configure/toolchain.configure#110-115

@depends("--enable-optimize", "MOZ_OPTIMIZE_FLAGS")
def moz_optimize(enable_optimize, env_flags):
    return "1" if enable_optimize or env_flags else None


set_config("MOZ_OPTIMIZE", moz_optimize)

The MOZ_OPTIMIZE_FLAGS environment variable has default value "", which means the option is always truthy, and MOZ_OPTIMIZE is always "1", and --disable-optimize has no effect.

https://searchfox.org/mozilla-central/rev/53e68046298557fae0c922230b595bb6689bf587/build/moz.configure/toolchain.configure#81-86

option(
    env="MOZ_OPTIMIZE_FLAGS",
    help="Extra optimization flags.",
    nargs=1,
    default="",
)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1906599

:sergesanspaille, since you are the author of the regressor, bug 1906599, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1913656 - Do not set default value for MOZ_OPTIMIZE_FLAGS environment variable to make the default state falsy. r?#firefox-build-system-reviewers!

Comment 3

[Mathew Hodson]

Bug 1906824 if where the return "1" if enable_optimize or env_flags else None was added.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76af1ed54229
Do not set default value for MOZ_OPTIMIZE_FLAGS environment variable to make the default state falsy. r=firefox-build-system-reviewers,sergesanspaille

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/76af1ed54229