1914138 - Remove history entry limitation for firefox view and sidebar

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P2)

Description

[Sarah Clements [:sclements] | PTO until Sept 8th]

We removed the max_history_rows limitation of 300 in bug 1886408, and after QA confirms there haven't been any issues we can make this change for all builds.

Comment 1

[Catalin Sasca, Desktop Test Engineering [:csasca]]

We haven't noticed any changes in the browser performance or any hangups by using profiles with lots of history. Verified on Win 10x 64 Ver 22H2 OS build 19045.4651, Win 10x64 Ver 22H2 build 19045.4780, macOS 14.1.2, macOS 14.6.1 and Ubuntu 24.04

Comment 2

[Sarah Clements [:sclements] | PTO until Sept 8th]

(In reply to Catalin Sasca, Desktop Test Engineering [:csasca] from comment #1)

We haven't noticed any changes in the browser performance or any hangups by using profiles with lots of history. Verified on Win 10x 64 Ver 22H2 OS build 19045.4651, Win 10x64 Ver 22H2 build 19045.4780, macOS 14.1.2, macOS 14.6.1 and Ubuntu 24.04

Thanks Catalin.

Comment 3

[Stuart Colville [:muffinresearch]]

(In reply to Catalin Sasca, Desktop Test Engineering [:csasca] from comment #1)

We haven't noticed any changes in the browser performance or any hangups by using profiles with lots of history. Verified on Win 10x 64 Ver 22H2 OS build 19045.4651, Win 10x64 Ver 22H2 build 19045.4780, macOS 14.1.2, macOS 14.6.1 and Ubuntu 24.04

Hi Catalin, just to confirm based on the linked bug 1886408 - was this also tested on older hardware too as well as profiles with large amounts of history.

Comment 4

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Hey Stuart, it was tested just on a lower specced Windows system, unfortunately we don't have access to other older hardware to test it on

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1914138 - remove history row limitation outside of Nightly, too, r?#sidebar-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fde436c0cb41
remove history row limitation outside of Nightly, too, r=sidebar-reviewers,sclements

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fde436c0cb41