Closed Bug 1914338 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 47737 - [@container] Make sure style(--prop: revert) parses but fail matching

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47737 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47737
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

[@container] Make sure style(--prop: revert) parses but fail matching

Modify tests to not pass for missing implementation. In particular,
modify expectation that style(--prop: revert) does not fail parsing, but
fail evaluation.

Change-Id: I448c07e9cb857d5f9835cdded11c9eae3ee4aba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5800693
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345292}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 77 subtests

Status Summary

Firefox

OK : 1
FAIL: 77

Chrome

OK : 1
PASS: 77

Safari

OK : 1
PASS: 77

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-conditional/container-queries/custom-property-style-queries.html [wpt.fyi]
    • style(--inner: true): FAIL
    • style(--inner:true): FAIL
    • style(--inner:true ): FAIL
    • style(--inner: true ): FAIL
    • style(--inner-no-space: true): FAIL
    • style(--inner-no-space:true): FAIL
    • style(--inner-no-space:true ): FAIL
    • style(--inner-no-space: true ): FAIL
    • style(--inner-space-after: true): FAIL
    • style(--inner-space-after:true): FAIL
    • style(--inner-space-after:true ): FAIL
    • style(--inner-space-after: true ): FAIL
    • style(--outer: true): FAIL
    • style(--outer:true): FAIL
    • style(--outer:true ): FAIL
    • style(--outer: true ): FAIL
    • style(--outer-no-space: true): FAIL
    • style(--outer-no-space:true): FAIL
    • style(--outer-no-space:true ): FAIL
    • style(--outer-no-space: true ): FAIL
    • style(--outer-space-after: true): FAIL
    • style(--outer-space-after:true): FAIL
    • style(--outer-space-after:true ): FAIL
    • style(--outer-space-after: true ): FAIL
    • outer style(--inner: true): FAIL
    • outer style(--inner:true): FAIL
    • outer style(--inner:true ): FAIL
    • outer style(--inner: true ): FAIL
    • outer style(--inner-no-space: true): FAIL
    • outer style(--inner-no-space:true): FAIL
    • outer style(--inner-no-space:true ): FAIL
    • outer style(--inner-no-space: true ): FAIL
    • outer style(--inner-space-after: true): FAIL
    • outer style(--inner-space-after:true): FAIL
    • outer style(--inner-space-after:true ): FAIL
    • outer style(--inner-space-after: true ): FAIL
    • outer style(--outer: true): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer:true): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer:true ): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer: true ): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-no-space: true): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-no-space:true): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-no-space:true ): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-no-space: true ): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-space-after: true): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-space-after:true): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-space-after:true ): FAIL linked bugs:Bug 1802763, Bug 1905350
    • outer style(--outer-space-after: true ): FAIL linked bugs:Bug 1802763, Bug 1905350
    • Query custom property with !important declaration: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Query custom property using var(): FAIL linked bugs:Bug 1802763, Bug 1905350
    • Query custom property including unknown var() reference: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Query custom property including unknown var() reference with non-matching fallback: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Query custom property including unknown var() reference with matching fallback: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Query custom property matching guaranteed-invalid values: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Style query with revert keyword is false: FAIL
    • Style query with revert-layer keyword is false: FAIL
    • Style query 'initial' matching: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Style query matching negated value-less query against initial value: FAIL linked bugs:Bug 1881854, Bug 1905350
    • Style query 'initial' not matching: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Style query matching value-less query against non-initial value: FAIL linked bugs:Bug 1881854, Bug 1905350
    • Style query 'initial' matching (with explicit 'initial' value): FAIL linked bugs:Bug 1892409, Bug 1905350
    • Style query matching negated value-less query against initial value (with explicit 'initial' value): FAIL linked bugs:Bug 1892409, Bug 1905350
    • Style query 'space' matching: FAIL linked bugs:Bug 1892409, Bug 1905350
    • Style query 'space' not matching: FAIL linked bugs:Bug 1892409, Bug 1905350
    • Style query 'inherit' matching: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Style query 'inherit' not matching: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Style query 'unset' matching: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Style query 'unset' not matching: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Match registered <length> custom property with px.: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Match registered <length> custom property with px via initial keyword.: FAIL linked bugs:Bug 1881854, Bug 1905350
    • Match registered <length> custom property with em in query.: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Match registered <length> custom property with em in computed value.: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Match registered <length> custom property with cqi unit.: FAIL linked bugs:Bug 1802763, Bug 1905350
    • Match registered <length> custom property with initial value.: FAIL linked bugs:Bug 1881854, Bug 1905350
    • Match registered <length> custom property with initial value via initial keyword.: FAIL linked bugs:Bug 1881854, Bug 1905350
    • Should only match exact string for numbers in non-registered custom properties: FAIL linked bugs:Bug 1881854, Bug 1905350
    • Spaces should not collapse in non-registered custom properties: FAIL linked bugs:Bug 1881854, Bug 1905350

New Tests That Don't Pass

  • /css/css-conditional/container-queries/custom-property-style-queries.html [wpt.fyi]
    • style(--inner: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-no-space: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-no-space:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-no-space:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-no-space: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-space-after: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-space-after:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-space-after:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--outer-space-after: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-no-space: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-no-space:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-no-space:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-no-space: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-space-after: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-space-after:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-space-after:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--inner-space-after: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after: true ): FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property with !important declaration: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property using var(): FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property including unknown var() reference: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property including unknown var() reference with non-matching fallback: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property including unknown var() reference with matching fallback: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property matching guaranteed-invalid values: FAIL (Chrome: PASS, Safari: PASS)
    • Style query with revert keyword is false: FAIL (Chrome: PASS, Safari: PASS)
    • Style query with revert-layer keyword is false: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'initial' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query matching negated value-less query against initial value: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'initial' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query matching value-less query against non-initial value: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'initial' matching (with explicit 'initial' value): FAIL (Chrome: PASS, Safari: PASS)
    • Style query matching negated value-less query against initial value (with explicit 'initial' value): FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'space' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'space' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'inherit' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'inherit' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'unset' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'unset' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with px.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with px via initial keyword.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with em in query.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with em in computed value.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with cqi unit.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with initial value.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with initial value via initial keyword.: FAIL (Chrome: PASS, Safari: PASS)
    • Should only match exact string for numbers in non-registered custom properties: FAIL (Chrome: PASS, Safari: PASS)
    • Spaces should not collapse in non-registered custom properties: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62648b1f9670 [wpt PR 47737] - [@container] Make sure style(--prop: revert) parses but fail matching, a=testonly https://hg.mozilla.org/integration/autoland/rev/866eff268400 [wpt PR 47737] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/62648b1f9670
https://hg.mozilla.org/mozilla-central/rev/866eff268400

Status: NEW → RESOLVED
Closed: 10 months ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.