191441 - Add config.ini option making GRE "private" vs "shared"

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

Mozilla installer's config.ini needs to offer option to have GRE installed in
the application dir (local GRE) as opposed to a global area.

There should also be a command line option to toggle this for quick testing.

Comment 1

[Doug Turner (:dougt)]

will this command flag also disable putting stuff in the registry?

Comment 2

[Sean Su]

by default, no.  However, if we can't stop it from registering the keys, then we
should at least have it be registered elsewhere.

Comment 3

[Daniel Veditz [:dveditz]]

We don't just want the location to be local, we want a true "private" copy.
Otherwise now the nightlies will interfere with folks who are trying to use a
shared copy.

At one point I thought I read something about still  making registry entries
(different ones) for private copies so later apps could still save download time
if they found a matching version and just copy it as needed.

Comment 4

[Sean Su]

Attachment: patch v1.0 (ns tree)

Comment 5

[Sean Su]

Attachment: patch v1.0 (moz tree)

This patch will allow the installer to tell the GRE installer to install GRE in
the same directory as mozilla (still no option to allow user to specify where
GRE should go).  This can be controlled via the config.ini or the cmdline flags
(-greLocal, -greShared).

The cmdline flags override the config.ini file.

This patch will create a new bug with the mozilla installer.  In the stub
installer, it will not properly save the downloaded files.  This is because GRE
uses the same directory right now and it saves it's files automatically *after*
mozilla has saved its files.  This should not be a 1.3b blocker though (IMO).

The uninstallation of both GRE and mozilla in this instance still works fine.

Comment 6

[Sean Su]

Comment on attachment 113304 [details] [diff] [review]
patch v1.0 (ns tree)

I have a newer patch I'm testing right now that handles the Save Downloaded
files appropriately for Mozilla.

Comment 7

[Sean Su]

Comment on attachment 113306 [details] [diff] [review]
patch v1.0 (moz tree)

I have a newer patch I'm testing right now that handles the Save Downloaded
files appropriately for Mozilla.

Comment 8

[Sean Su]

Attachment: patch v1.1 (ns tree)

Comment 9

[Sean Su]

Attachment: patch v1.1 (moz tree)

patch that also correctly saves downloaded files.

Comment 10

[Samir Gehani]

Comment on attachment 113407 [details] [diff] [review]
patch v1.1 (ns tree)

r=sgehani

Comment 11

[Samir Gehani]

Comment on attachment 113409 [details] [diff] [review]
patch v1.1 (moz tree)

r=sgehani

Comment 12

[Sean Su]

Attachment: patch v1.2 (ns tree)

updated given dveditz's comments

Comment 13

[Sean Su]

Attachment: patch v1.2 (moz tree)

updated given dveditz's comments

Comment 14

[Doug Turner (:dougt)]

i can't read a config.ini as well as I like.  can you summarize these changes?

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 113462 [details] [diff] [review]
patch v1.2 (moz tree)

sr=dveditz

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 113461 [details] [diff] [review]
patch v1.2 (ns tree)

sr=dveditz

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 113461 [details] [diff] [review]
patch v1.2 (ns tree)

a=dveditz

Comment 18

[Daniel Veditz [:dveditz]]

Comment on attachment 113462 [details] [diff] [review]
patch v1.2 (moz tree)

a=dveditz

Comment 19

[Sean Su]

gre's config.it:
  * updated to use the $ProductNameInternal$ for the instead of
    $ProductNameNoVersion$.  They are both the same, except that the
    ProductNameInternal is used more widely.
  * removed the locate for previous install path section.  It will now always
    install to the [common files] dir even if a previous GRE was installed
    elsewhere.
  * updated the dir name of where the downloaded files get saved to from
    'Setup' to 'Setup GRE'.

mfcembed's config.it:
  * updated to use the $ProductNameInternal$ for the instead of
    $ProductNameNoVersion$.  They are both the same, except that the
    ProductNameInternal is used more widely.

mozilla's config.it:
  * updated to use the $ProductNameInternal$ for the instead of
    $ProductNameNoVersion$.  They are both the same, except that the
    ProductNameInternal is used more widely.
  * Added 'GRE Type' to dictate if GRE should be installed as 'Local' or
    'Shared'.  It will default to 'Shared' unless otherwise specified.
  * Added 'GRE Private Key' to specify the subkey to create within
    HKEY_LOCAL_MACHINE for the Private GRE key.  This is dictated in the
    config.ini file because it needs to be different for Netscape's
    config.ini file.

Comment 20

[Sean Su]

forgot to mention that for the private gre key supplied in the config.ini file,
it will append '_[Product NameInternal]' to the key:

  ie: given 'Software\mozilla.org\GRE_PRIVATE' for mozilla, it will create
      given 'Software\mozilla.org\GRE_PRIVATE_Mozilla' in the windows registry.

Comment 21

[Sean Su]

both patches checked in.  Starting with tomorrow's builds:
  mozilla: defaults to local/private GRE (GRE installs ontop of Mozilla dir)
  ns:      defaults to shared GRE (GRE installed into [common files] dir, same
           as before)

Users can override these defaults via the following cmdline args:
  -greLocal   - forces GRE to be installed locally (ontop of the app's dir)
  -greShared  - forces GRE to be installed in a shared dir ([common files] dir)

closing bug as fixed.

Comment 22

[Malcolm Rowe]

I'm curious - why was jsj3250.dll removed from packages-win?  I'm sure there's a
valid reason, it just doesn't look like it's got anything to do with the rest of
this patch.

Comment 23

[Sean Su]

good eye.  it was part of a patch that got accidentally picked up by these
patches.  It fixes bug 191213.  jsj3250.dll is currently being installed in both
the GRE and Mozilla dirs.  It should only be in GRE.

Comment 24

[Grace Bush]

verified mozilla build 2003031108