1914411 - shouldInlineCallDirect: disallow inlining of imported functions

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Julian Seward [:jseward]]

The lack of such a test leads to
Assertion failure: funcIndex >= numFuncImports, at js/src/wasm/WasmMetadata.h:269
in

js::wasm::IonCompileFunctions
-> IonBuildMIR
   -> EmitBodyExprs
      -> EmitCallRef
         -> FunctionCompiler::shouldInlineCallDirect
            -> CodeMetadata::funcDefFeatureUsage

Comment 1

[Julian Seward [:jseward]]

Attachment: Bug 1914411 - shouldInlineCallDirect: disallow inlining of imported functions. r=rhunt.

The lack of such a check has been observed to lead to
Assertion failure: funcIndex >= numFuncImports, at js/src/wasm/WasmMetadata.h:269

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28a1be056b1a
shouldInlineCallDirect: disallow inlining of imported functions.  r=rhunt.

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/28a1be056b1a