1914429 - [X11] Right-Click functionality suddenly turned buggy - wrong popup placement

Status: NEW

(Core :: XUL, defect, P3)

Description

[Manan Sharma]

Attachment: Screencast from 08-22-2024 09:36:20 PM.webm

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

1. Open Firefox.
2. Find a hyperlink
3. Right click any hyperlink using either the external Mouse, the Trackpad, or the middle-mouse button.

Actual results:

Instead of getting the chance to select an option of choice, i.e. to open in a new tab, or add to bookmarks. I am immediately finding the right-click context menu shut down as if I have selected a random option, and am taken to the random option selected (like opening firefox relay), etc.

Expected results:

I should have been able to chose an option of choice from the right-click menu.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I can reproduce the issue on Firefox on xwayland and X11, but not on wayland.

This can happen on any page if the right-clicked mouse position is in an area where the context menu would appear.

STR(For example, but not limited to):

1. Start Firefox with new profile on Linux
2. Move the browser to the right side of the screen
3. Open New Tab Page
4. Select All (Ctrl+A)
5. Right mouse click on the right part of the “Thought-provoking stories” image.

Screencast: https://youtu.be/EEkYzvrEYOM

Setting ui.context_menus.after_mouseup to true is a workaround.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Please attach your about:support page.
Thanks.

Comment 4

[Manan Sharma]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #3)

Please attach your about:support page.
Thanks.

Apologies for the late response.
You'll find the about:support page attached here: https://www.mediafire.com/file/8pd6mxty1esysat/Troubleshooting_Information.xhtml/file

Comment 5

[Martin Stránský [:stransky] (ni? me)]

It's X11 where popups are placed by us.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Manan Sharma]

The Bug is still live. Encountered it recently on Firefox 134.0.2

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Is that a recent regression? Have you seen it before?

For instance can you see mozregression to find broken commit?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Use_Mozregression_tool
Thanks.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

I see you use more than one monitor. Do you see the bug if you turn one monitor off?

Comment 10

[Alice0775 White]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #8)

Is that a recent regression? Have you seen it before?

For instance can you see mozregression to find broken commit?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Use_Mozregression_tool
Thanks.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=369a5ee3a2880a4a98df3a00bf3db8d8f36b181b&tochange=19a1743ceb2e035e571012e88d25275ce627b925

The issue triggered by Bug 1251634.

I can reproduce the issue on Linux Mint 22 Cinnamon.
This problem can be easily reproduced with a very small screen resolution and DPI scaling above 150%. And it occurs when right-clicking near the right edge of the screen.
The ONLY SOLUTION is to set ui.context_menus.after_mouseup to true.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Alice0775 White from comment #10)

This problem can be easily reproduced with a very small screen resolution and DPI scaling above 150%. And it occurs when right-clicking near the right edge of the screen.
The ONLY SOLUTION is to set ui.context_menus.after_mouseup to true.

What do you mean with 'very small screen resolution'? How is your screen configured?

Comment 12

[Martin Stránský [:stransky] (ni? me)]

From the report above the screen sizes are pretty common:

Display0	1920x1080@60Hz scales:1.000000|1.000000
Display1	1366x768@60Hz scales:1.000000|1.000000

Comment 13

[Alice0775 White]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #11)

(In reply to Alice0775 White from comment #10)

This problem can be easily reproduced with a very small screen resolution and DPI scaling above 150%. And it occurs when right-clicking near the right edge of the screen.
The ONLY SOLUTION is to set ui.context_menus.after_mouseup to true.

What do you mean with 'very small screen resolution'? How is your screen configured?

I tested on vmware workstation client. And reduce the height of the VMware client window to about 450px.

Comment 14

[Alice0775 White]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #12)

From the report above the screen sizes are pretty common:

Display0	1920x1080@60Hz scales:1.000000|1.000000
Display1	1366x768@60Hz scales:1.000000|1.000000

It can be reproduced if very long context menu due to add-ons.
OR
See Comment #2. when selection text, images, and links are reflected in the context menu
(I.e., Most of the context menus are displayed and popups are longer).

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1251634

Comment 16

[Emilio Cobos Álvarez [:emilio]]

I think comment 0 and comment 2 are slightly different... Comment 2 is pretty fixable at least.

I think comment 0 has something else going on... Reporter, does it reproduce on a regular build? I think some of the custom styling is effectively positioning the menu directly under the cursor. That doesn't happen on an unmodified build even with a massively tall context menu here.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1251634

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 20

[Manan Sharma]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #16)

I think comment 0 and comment 2 are slightly different... Comment 2 is pretty fixable at least.

I think comment 0 has something else going on... Reporter, does it reproduce on a regular build? I think some of the custom styling is effectively positioning the menu directly under the cursor. That doesn't happen on an unmodified build even with a massively tall context menu here.

Now that I do have an unmodified version of firefox installed, I can no longer reproduce the original bug, and the right click thing works perfectly fine. Although, I don't know if it is related but somewhere I read that Linux handled right clicks differently, since I have to release my right clicks after selecting the correct option (unlike on windows) - when I'm using obsidian (which I don't think is relevant here), but the right click that I experience there is akin to what I mentioned in the Original BugReport. I reiterate that I cannot reproduce the bug on an unmodified firefox build as of now. Sorry for letting the bugreport hang around stale - I was embroiled in life. (In reply to Manan Sharma from comment #7)

The Bug is still live. Encountered it recently on Firefox 134.0.2

The above was more likely an actual issue since the version of Firefox I was using at the time was more or less unmodified (having gone out of my ricing phase for the time being).