1914432 - History page titles are truncated too early

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Screenshot 2024-08-22 at 12.10.25 PM.png

There is a lot of real estate that is not being utilized. This is due to the “delete” button, which takes up space in the DOM even when it is not showing. We could potentially use the whole row for the title unless the user is currently hovering over it.

Synced Tabs seems to be closer to the expected behavior, probably because there is no delete button there.

Comment 1

[Yulia Popova]

The tab title should only be truncated when the history item is hovered and the trash icon appears. When the trash/close icon is not visible, the title should utilize as much space as possible.

Comment 2

[Yulia Popova]

Attachment: History truncation .png

Comment 3

[Yulia Popova]

In addition wanted to mention that the trash icon and its behavior wasn't implemented according to spec. It has been documented in Visual changes doc and as far as I know there is already a bug filed that should address it

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1914432 - Truncate tab titles without losing space to delete button r=#sidebar-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d46ff0ed2b64
Truncate tab titles without losing space to delete button r=sidebar-reviewers,jsudiaman

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d46ff0ed2b64