1914438 - Long press on New tab button does not offer to open a new Container tab

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Ania]

STRs

1. Enable vertical tabs in the latest Nightly.
2. Make a long press on the new tab button in the vertical tabs.

Expected results

1. Container tabs new tab modal opens under the new tab button (see attached screenshot of this behavior in the horizontal tabs).

Actual result

1. Nothing happens on long press.

Comment 1

[Ania]

Attachment: Screen Shot 2024-08-22 at 12.14.01 PM.png

Comment 2

[Sam Foster [:sfoster] (he/him)]

I don't have all the context, but ISTM that once Bug 1899346 lands, we could do a simple follow-up here to move the new tab button from the horiztonal tabstrip toolbar into the vertical toolbar - which gives us this behavior for free. Currently that will get moved to the nav-bar and we create a new one in the sidebar template which doesnt have all the same behavior.

Comment 3

[Sarah Clements [:sclements]]

I mentioned this on slack, so just putting it here for context that new tab buttons in the horizontal tab strip can be removed, and therefore we'd have to pull them out of the customize panel to put them into the vertical tab strip if a user has done so which seemed like an unnecessary bit of complexity. There are also styling and key navigation/tab index differences.

It should be a simple fix to add the "vertical-new-tab-button" to this bit of code here in order to show the container popup.

Comment 5

[Sarah Clements [:sclements]]

I believe Ania wanted this in for 132, so changing it to P2.

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=#sidebar-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/870b68c06bd7
Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_newtabButton.js

Backout link

Push with failures

Failure log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbf1cbd2f18f
Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bbf1cbd2f18f

Comment 12

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Nightly 131.0a1 build from 2024-08-22, using Windows 11, while following the steps from Comment 0.
Verified as fixed on Firefox 132.0b5 (with privacy.userContext.enabled pref set to true), using macOS 14.7, Windows 11 and Ubuntu 22.04. Container tabs new tab modal opens under the new tab button.