1914455 - Sidebar launcher and panel appear in the incorrect order sometimes on restart

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Screenshot 2024-08-22 at 8.39.47 AM.png

See screenshot. There was a recent change moving setPosition to init in browser-sidebar.js, uncovering the need for removing order from SessionStore data to avoid conflict.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1914455 - Remove "order" from sidebar SessionStore data r=#sidebar-reviewers

We can rely on the global pref for this. setPosition in browswer-sidebar.js looks
at the pref sidebar-position_start to determine "order" on init and on reversePosition

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ad87ee54e3
Remove "order" from sidebar SessionStore data r=sidebar-reviewers,sessionstore-reviewers,dao,kcochrane

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/49ad87ee54e3

Comment 4

[Daniel Bodea [:danibodea]]

I would like to attempt this bug's fix verification. Could you please provide us with some steps to reproduce? Thank you.

Comment 5

[Nikki Sharpley (:nikkis) (she/her)]

:danibodea, no worries!

STR:

1. Open a window and set the sidebar.revamp pref to true in Firefox Labs
2. Open any panel (eg. Customize Sidebar)
3. Quit Firefox.
4. Restart the browser and restore the session.

Expected - The sidebar panel should be open and the order of the elements should be sidebar-main, sidebar-splitter, sidebar-box (opposite for RTL or sidebar.position_start = false)

Actual - The sidebar-box was before the sidebar-main and sidebar-splitter elements.

Comment 6

[Daniel Bodea [:danibodea]]

I can't seem to be able to reproduce your issue on MacOS11 or MacOS14 ARM with Nigyhtly v131.0a1 from 2024-08-26. The provided steps to reproduce are not valid and verification is not possible.
I've tried creating random history and data to simulate a "normal account" and also tried them on fresh user profiles, but the UI issue was not observed.

Do you think you can provide an improved set of steps to reproduce?
Do you know whether this issue could be specific to a device or an operating system?
Which MacOS version have you observed it on?
Thanks!

Comment 7

[Nikki Sharpley (:nikkis) (she/her)]

This was from four months ago so I am not sure what MacOS version I was on. I'm sorry I can't provide any further STR - it was a random occurrence at start up. I observed it on a local build. Thanks!

Comment 8

[Daniel Bodea [:danibodea]]

Removing qe-verify+ tag since STR cannot be provided. Verification can not be provided.