1914633 - Regression in system messages for XMPP

Status: VERIFIED FIXED

(Chat Core :: XMPP, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: Screenshot

I suspect this is a regression from bug 1889422? I checked the protocol log and this isn't just someone with a silly name.

Joe -- would you be able to look into this since you took a look at the migrations?

Comment 1

[Patrick Cloke [:clokep]]

Note that IRC looks fine, so it is something with the XMPP code in particular.

Comment 2

[Martin Giger [:freaktechnik]]

https://searchfox.org/comm-central/rev/6008b146dd47177476bea019f3f2743391cf473d/chat/protocols/xmpp/xmpp-base.sys.mjs#453 needs logic to build the correct paramObject for this case.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1914633 - Fix conversation-message-parted XMPP message string placeholder replacement. r=clokep

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9941cfff2d39
Fix conversation-message-parted XMPP message string placeholder replacement. r=clokep

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9420684 [details]
Bug 1914633 - Fix conversation-message-parted XMPP message string placeholder replacement. r=clokep

[Approval Request Comment]
Regression caused by (bug #): bug 1889422
User impact if declined: Some system messages in XMPP conversations are missing usernames or reasons.
Testing completed (on c-c, etc.): Manual testing.
Risk to taking this patch (and alternatives if risky): Low risk, worst case the strings still don't have translated placeholders (or other strings are missing them).

Comment 6

[Patrick Cloke [:clokep]]

This is working for me on 131.0b1. I haven't tested all the versions (with a message, without a message, etc.) but the basic cases seem to work.

Comment 7

[Corey Bryant]

Martin, we aren't planning to release any more 115 patch releases.

Comment 8

[Martin Giger [:freaktechnik]]

Comment on attachment 9420684 [details]
Bug 1914633 - Fix conversation-message-parted XMPP message string placeholder replacement. r=clokep

Sorry, picked the wrong flag from muscle memory or something...

[Approval Request Comment]
Regression caused by (bug #): bug 1889422
User impact if declined: Some system messages in XMPP conversations are missing usernames or reasons.
Testing completed (on c-c, etc.): Manual testing.
Risk to taking this patch (and alternatives if risky): Low risk, worst case the strings still don't have translated placeholders (or other strings are missing them).

Comment 9

[Corey Bryant]

Comment on attachment 9420684 [details]
Bug 1914633 - Fix conversation-message-parted XMPP message string placeholder replacement. r=clokep

[Triage Comment]
Approved for esr128

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/7f8174cc4aed