1914650 - Context menus generated from the bookmarks toolbar are not closed when the toolbar gets hidden on page load

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[keshav]

Attachment: Screenshot (88).png

Steps to reproduce:

Create a book mark with page, Click The Bookmarked page, while the website is rendering Right Click on The book mark, When the Page is rendered ,Clicking on the Delete BookMark Option doesnt delete the bookmark

Actual results:

right Click on BookMark Options stays open when website is completely renderd,
Clicking on Provided Option has no affect

Expected results:

The right Click option menu when right clicked on saved book-mark should be canceled.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Marco Bonardo [:mak]]

Could you please express the steps to reproduce as a clearer bullet list, or post a screencast of the bug, I'm having difficulties understanding the steps as they are. Is the bookmarks toolbar involved?

Comment 4

[keshav]

(In reply to Marco Bonardo [:mak] from comment #3)

Could you please express the steps to reproduce as a clearer bullet list, or post a screencast of the bug, I'm having difficulties understanding the steps as they are. Is the bookmarks toolbar involved?

Hi Added Screen Cast for the bug i faced when accessing menu options on bookmark, happens a lot when slow internet.
Not Sure if this is a bug or not. close the ticket if this is expected behavior.

[https://drive.google.com/file/d/1eY0bA8Sv27PkZ6E3ltmq0Ye2bf_hYQqy/view?usp=drive_link](Video Link to Screen Cast).

Comment 5

[Marco Bonardo [:mak]]

Thank you that helps a lot.

This is due to the Only show in new tab option of the Bookmarks toolbar, when a page that is not new tab loads, the toolbar gets hidden, and it looks like it's not handling context menus that were open in the meanwhile. The context menu cannot work in that condition as the original DOM node is gone.

The situation of the user having to use the context menu just immediately after a load is quite uncommon, and when it's necessary it would be better to set the toolbar to Always Show, or to open in a new tab.

We could handle this case by closing any generated context menu when the toolbar gets hidden. I must note however this may be more common on slow connections, and then closing the menu while the user is still using it may not be great. Maybe we could delay toolbar hiding until the context menu is closed? Provided that doesn't require code hard to maintain in the future. Or maybe we could hide the toolbar earlier than onLocationChange, though if the load doesn't go through we may end up in an unstable situation of new tab not showing the toolbar.

Comment 6

[keshav]

(In reply to Marco Bonardo [:mak] from comment #5)

Thank you that helps a lot.

This is due to the Only show in new tab option of the Bookmarks toolbar, when a page that is not new tab loads, the toolbar gets hidden, and it looks like it's not handling context menus that were open in the meanwhile. The context menu cannot work in that condition as the original DOM node is gone.

The situation of the user having to use the context menu just immediately after a load is quite uncommon, and when it's necessary it would be better to set the toolbar to Always Show, or to open in a new tab.

We could handle this case by closing any generated context menu when the toolbar gets hidden. I must note however this may be more common on slow connections, and then closing the menu while the user is still using it may not be great. Maybe we could delay toolbar hiding until the context menu is closed? Provided that doesn't require code hard to maintain in the future. Or maybe we could hide the toolbar earlier than onLocationChange, though if the load doesn't go through we may end up in an unstable situation of new tab not showing the toolbar.

Yes, It was quite difficult to recreate this issue, i stumbled upon it when steam was updating a bunch of games.
maybe when new Tab is opened it could change context menu display properties, This approach could also fix issue when a Tab is duplicated through List all Tabs, Close all duplicate tabs option is not enabled even though there are duplicate Tabs open.

[https://ibb.co/0DscLCc] (Screen Shot Link)

Comment 7

[James Teow [:jteow]]

We talked about this in our bug scrub and we're leaning towards this part in Comment 5:

Maybe we could delay toolbar hiding until the context menu is closed? Provided that doesn't require code hard to maintain in the future.